Closed Bug 1616273 Opened 3 years ago Closed 2 months ago

Wait for "reloaded" event when navigating to a new page from webconsole tests

Categories

(DevTools :: Console, task, P1)

task

Tracking

(firefox105 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

This is to followup the suggestion from Julian during this review:
https://phabricator.services.mozilla.com/D62803#inline-379617

There is quite a few intermittents in this try run, but only one of them is about the console, so it looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=596a80134a61f961590e62b1c21aa5b3ccc2fbc5

The one failing is devtools/client/webconsole/test/browser/browser_webconsole_trackingprotection_errors.js , an OOM in debug mode, which seems to be an already existing one.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b1719f53272
Wait for webconsole reloaded event from navigateTo test helper. r=nchevobbe
Priority: -- → P1

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(poirot.alex)

I don't have enough cycle to look into the test failure introduced by this test cleanup patch.

Assignee: poirot.alex → nobody
Flags: needinfo?(poirot.alex)
Attachment #9127278 - Attachment is obsolete: true
Assignee: nobody → nchevobbe
Attachment #9127278 - Attachment is obsolete: false
Status: NEW → ASSIGNED
Attachment #9127278 - Attachment description: Bug 1616273 - Wait for webconsole reloaded event from navigateTo test helper. → Bug 1616273 - [devtools] Wait for webconsole reloaded event in _watchForPanelReload.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea3856851fa5
[devtools] Wait for webconsole reloaded event in _watchForPanelReload. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.