Closed Bug 1616292 Opened 4 years ago Closed 4 years ago

Eager evaluation: tweak string and number colors

Categories

(DevTools :: Console, enhancement)

enhancement
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
Firefox 75
Tracking Status
firefox75 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Based on discussion around:
https://github.com/firefox-devtools/ux/issues/103#issuecomment-583294197

In eager evaluation results, magenta strings are very attention-grabbing and we probably want to use a shade of gray instead.

And if we do, we may turn the Number types gray as well since it would be the only remaining color (outside of errors)?

Victoria asks if we should use the same colors as in Debugger (dark blue for strings and numbers):
https://github.com/firefox-devtools/ux/issues/103#issuecomment-587544000

It would be interesting, but that means overriding Reps colors to use the same values as CodeMirror colors, and I'm not super fond of that solution. I'd rather go with gray for now.

Assignee: nobody → florens
Status: NEW → ASSIGNED
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/3d2241d9040e
Set more eager evaluation output colors to grays; r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: