1616301 - context switching should refer to target instead of thread

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Jason Laster [:jlast]]

[alex] In initial context selector patch, most of the patch mentions “thread” whereas this is rather a “target”.

registerThread is a good example (link)
function registerThread(targetFront) {
return async function(dispatch) {
const threadFront = await targetFront.getFront("thread");
const thread = {
actor: threadFront.actor,
url: targetFront.url,
type: getTargetType(targetFront),
name: targetFront.name,
serviceWorkerStatus: targetFront.debuggerServiceWorkerStatus,
// NOTE: target is used because when the target is destroyed
// its ID and associated thread front are removed.
_targetFront: targetFront,
};

Isn’t the context selector more about targets than threads?
It is often better to work with a target as you can derive everything from it. While it is harder to get the console front, if you only have the thread front.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1616301 - Handle targets in toolbox store instead of threads. r=ochameau,jlast.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1616301 - Rename clearTarget into unregisterTarget. r=jlast.

This is more consistent with the registerTarget action we
have

Depends on D68760

Comment 4

[Chris Peterson [:cpeterson]]

Tentatively moving P1 Fission M6 bugs to M6a.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c54971ad0117
Handle targets in toolbox store instead of threads. r=jlast.
https://hg.mozilla.org/integration/autoland/rev/c3c65ed42418
Rename clearTarget into unregisterTarget. r=jlast.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c54971ad0117
https://hg.mozilla.org/mozilla-central/rev/c3c65ed42418