Closed Bug 1616348 Opened 5 years ago Closed 1 year ago

Add .nvmrc file to browsertime

Categories

(Testing :: Performance, enhancement, P3)

Version 3
enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: sparky, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxp])

There have been some node versioning issue reports today (after the BT8 upgrade) and one of the solutions for them is to use nvm to handle the different node versions. With nvm, we can add a .nvmrc file somewhere in our code and that would get picked up by nvm use so that the users won't have to figure out the node version they need anytime they make a switch or when we upgrade the required node version.

We have two options here, either we add the .nvmrc file to tools/browsertime/ or add it to the sitespeedio repo. At the same time, we should output a warning message when we detect that the node version is not high enough. There's some prior work for this available here: https://bugzilla.mozilla.org/show_bug.cgi?id=1611301

Flags: needinfo?(gmierz2)
Flags: needinfo?(gmierz2)
Priority: P2 → P3
Severity: normal → S3

@sparky is this still valid?

Flags: needinfo?(gmierz2)

Yes this is still valid, but it's a very low priority atm.

Flags: needinfo?(gmierz2)
Whiteboard: [fxp]

Closing since we now pull the correct node version from toolchains in CI.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.