Closed
Bug 1616374
Opened 5 years ago
Closed 5 years ago
Update comment in ds/Sort.h to make it easier to find
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
Details
Attachments
(1 file)
std::stable_sort is not allowed inside SM because it allocates heap memory internally, which angers check_vanilla_allocations.py. The correct alternative is MergeSort, in ds/Sort.h. This patch adds a comment to make it easier to figure this out via searchfox.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d25ea1954d99
Update comment DONTBUILD r=jwalden
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•