1616460 - bookmarks tree view can cause bookmarks to be moved even when it's not visible

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Bug 1605881 worked around the 1 case where we know for sure that unexpected bookmark moves where happening, but the core issue remains and this could theoretically happen in other scenarios due to a fundamental issue in the bookmark tree view. See bug 1605881 comment 10 for a detailed description of what's wrong and what can be done to fix it.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think this is important, also from a perf point of view

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Let me sup up what we should do:

1. when the tree is hidden, bailout of onFolderTreeSelect
2. if possible, distinguish selections made by the user from automated selections made by us, bailout of onFolderTreeSelect for non-user-activated selections. This may be tricky, we should somehow know if the even causing the select was a MouseEvent or KeyboardEvent.
3. when we hide/show the tree, create/destroy the result, every time. It's pointless to have it always alive, when editing a bookmark from the star panel is not a common operation

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1616460 - Star panel tree view can move bookmarks even when it's not visible. r=standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e2bc58d9c3
Star panel tree view can move bookmarks even when it's not visible. r=Standard8

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/99e2bc58d9c3