1616536 - add maxmind db version to __heartbeat__

Status: RESOLVED FIXED

(Location :: General, enhancement, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We have the alembic version in the /__heartbeat__ response. We should add the maxmind db version to /__heartbeat__ to help us keep track of updates.

Pretty sure we want the build_epoch value which is in the db metadata. I don't see any other version-y values available.

• https://maxmind.github.io/MaxMind-DB/
• https://geoip2.readthedocs.io/en/latest/#geoip2.database.Reader.metadata

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is pretty straight-forward. It's almost all done already since /__heartbeat__ has the maxmind db age.

Grabbing this to do now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 1077: bug 1616536: add geoip version to __heartbeat__

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #1077: "bug 1616536: add geoip version to heartbeat" in 0d3bb34.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I want to change this. Currently, the value is the build epoch. I want to change it to an iso-8601 version of that.

So instead of something like:

• 1582570094

we should switch it to something like this:

• 2020-02-24T13:48:14Z

That matches how Telemetry is tracking their maxminddb version. Having the version format the same makes things easier.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 1078: bug 1616536: change format of maxmind db version in /__heartbeat__

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #1078: "bug 1616536: change format of maxmind db version in /heartbeat" in 3c47c95.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This got deployed. Marking as FIXED.