1616591 - Make APZ logging enable-able at runtime (use moz log)

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

It would be useful to migrate the APZ and input logging so that they can be enabled at runtime instead of requiring compile-time ifdef changes. This way people experiencing issues can enable the logs at runtime via prefs or similar and provide useful information. The networking team has similar functionality for networking bugs that seems to be helpful to them in debugging rare issues.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I have patches that build locally but I still need to do a try push to verify they build everywhere. My try push access was revoked while I was away and I'm in the process of getting that restored. I'll put the patches up for now but they might need some tweaking.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1616591 - Make all the APZ log statements build again if enabled. r?botond

• Some breakage in FocusState/FocusTarget was introduced when the LayersId struct
  was introduced in bug 1448490; printing LayersId type now requires using the
  cast operator to get back the underlying uint64_t.
• Some breakage was introduced in APZCTreeManager by bug 1552608 when it
  introduced the HitTestResult structure.
• Some breakage in SimpleVelocityTracker seems to have been there since it
  landed as it tries to access a protected member in Axis. Added a public
  method to expose this as needed.
• Some breakage in ActiveElementManager was introduced in bug 1266595 when the
  runnable was wrapped in a RefPtr.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1616591 - Migrate APZ logging to use the MOZ_LOG framework. r?botond

The MOZ_LOG framework is the canonical Gecko logging framework, and provides
better control over what gets logged and where it goes, as well as provides
additional options like process/thread/timestamp prefixing of log output. This
patch does the minimum necessary to migrate the logs; each pre-existing
logging define is converted to a log module and all pre-existing log lines are
defaulted to LogLevel::Debug.

In addition, this prevents future breakage in the logging since everything
gets compiled on at least some configurations (e.g. non-Release, non-Android
builds).

Depends on D63547

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e9bc51fc278ce6c6fe8fe7ca533e90203c4b593e

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddcb3e57bb7d
Make all the APZ log statements build again if enabled. r=botond
https://hg.mozilla.org/integration/autoland/rev/1499b7431d91
Migrate APZ logging to use the MOZ_LOG framework. r=botond

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ddcb3e57bb7d
https://hg.mozilla.org/mozilla-central/rev/1499b7431d91