1616594 - Two frame builder configs during frame building

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

in FrameBuidler::build we pass a FrameBuilder object coming from the render backend thread, as well as scene.config. The two are not necessarily in sync and it's quite error-prone.
Let's have a single one or have separate types.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1616594 - Use the scene's frame builder config during frame building. r=gw

The render backend's frame builder config is kept only in order to send updates to the scene builder's frame builder config which will update the scene's in the next transaction. If need be the scene configs can be updated right away by looping over the documents. This avoids confusing bugs where only updating the backend's config affects the visibility pass but not the rest.

Depends on D63336

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae6a9e447f8d
Use the scene's frame builder config during frame building. r=gw

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ae6a9e447f8d