1616600 - The Firefox process will not shut down after closing the browser if the Camera and Microphone are allowed in different tabs

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: 2020-02-19_15h06_56.mp4

[Affected versions]:
Nightly 75.0a1

[Affected platforms]:
Platforms: all

Steps :

1. Open the Firefox Browser and https://jsfiddle.net/jib1/r60bzmrs/
2. Alow the camera permission prompt.
3. Open the Firefox Browser and https://jsfiddle.net/jib1/r60bzmrs/ in a second tab.
4. Close the Firefox process.

Expected Results :
The Firefox process should close without issues.
Actual Results :
The Firefox process will not shutdown upon closing the browser.

Note: Please note that the same issue occurs with the microphone permission (or both at the same time) (https://jsfiddle.net/jib1/59og5vhn/).
After the user allows the microphone to start in two separate tabs and closing the browser the Firefox process will not shutdown.

This issue only occurs on Windows and Ubuntu, it seems Mac will shutdown the process if you quit the browser with right click > Quit.

I've also performed a Mozregression on this issue and here are the results :
Last known GOOD build:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ea063dbb6c1b5cdfedbf232e234a7f9c492b44af&tochange=cf63a0b7bd7d7110fb917cf158097a6495c65ccd
First known BAD build:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d827ca47ac5bdc005f6854c2534cd0c4bcd37db0&tochange=cf63a0b7bd7d7110fb917cf158097a6495c65ccd

Comment 1

[Dan Minor [:dminor]]

Maybe a regression from Bug 1601301?

Comment 2

[Dan Minor [:dminor]]

[Tracking Requested - why for this release]: Regression causing shutdown hang.

Comment 3

[Julien Cristau [:jcristau]]

Marking 74 as affected based on the regression range, Rares can you double check this affects the latest 74 beta build?

Comment 4

[Rares Doghi, Desktop QA]

Yes, this issue only affects Firefox Beta 74 and Nightly 75.

Comment 5

[Neil Deakin]

Have a fix here. The issue is caused only when webrtc is used in subframes, where the indicator window is not being closed.

The underlying cause can also manifest on Mac. Closing the window leaves the sharing items on the Window menu, whereas they should be removed when no more sharing is used.

Comment 6

[Neil Deakin]

Attachment: Bug 1616600, properly update the tab-indicator state when a tab is closed; it previously wasn't being removed properly from the per-tab indicator map when the indicator was from a subframe,r=johannh

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Neil, it seems the patch is r+, any reason not to land it? Our last betas for uplift are tomorrow and Friday, could we uplift it? Thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0042f4581946
properly update the tab-indicator state when a tab is closed; it previously wasn't being removed properly from the per-tab indicator map when the indicator was from a subframe,r=johannh

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0042f4581946

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in our latest Nightly build 75.0a1 (2020-02-26) on Windows 10 and Ubuntu 18.04.

Comment 11

[Julien Cristau [:jcristau]]

Please request beta uplift asap so we can avoid shipping the regression in 74.

Comment 12

[Neil Deakin]

Comment on attachment 9127926 [details]
Bug 1616600, properly update the tab-indicator state when a tab is closed; it previously wasn't being removed properly from the per-tab indicator map when the indicator was from a subframe,r=johannh

Beta/Release Uplift Approval Request

• User impact if declined: When webrtc (video, screensharing) is used in some pages, closing the window doesn't close the indicator popup, leading users to think that the browser won't shutdown.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just cleans up some state properly.
• String changes made/needed: None

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9127926 [details]
Bug 1616600, properly update the tab-indicator state when a tab is closed; it previously wasn't being removed properly from the per-tab indicator map when the indicator was from a subframe,r=johannh

Low risk, covered by tests, uplift approved for 74 beta 9, thanks.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7409d1b1c5a

Comment 15

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta build 74.0b9 on Windows 10 and Ubuntu 18.04.