1616625 - Error when calling tabs.update with {active: true}

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P2)

Description

[Christian Sadilek [:csadilek]]

We ran into this when testing uBlock. The logger / zap / picker buttons in the action popup try to find and select an existing tab before opening a new one.

Bug in Fenix: https://github.com/mozilla-mobile/fenix/issues/8467

The error:

BrowserApp.selectTab is not a function ext-tabs.js:408
    update chrome://geckoview/content/ext-tabs.js:408
    update self-hosted:878
    result resource://gre/modules/ExtensionParent.jsm:1106
    withPendingBrowser resource://gre/modules/ExtensionParent.jsm:737
    result resource://gre/modules/ExtensionParent.jsm:1106
    callAndLog resource://gre/modules/ExtensionParent.jsm:1068
    recvAPICall resource://gre/modules/ExtensionParent.jsm:1105
    AsyncFunctionNext self-hosted:696

We also see:

Error: Invalid tab ID: 10069

Comment 1

[Rob Wu [:robwu]]

I mentioned this before at https://bugzilla.mozilla.org/show_bug.cgi?id=1565536#c1

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1616625 - Move Extension session delegates to SessionController.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1616625 - Move TabDelegate to be per-WebExtension and per-GeckoSession.

Before this patch, the TabDelegate was "special" as in it had just one global
delegate that receives events for all extensions and sessions. This was done to
allow mochitests to call tabs.create and tabs.remove.

This hack is no longer needed as now we can notify the embedding layer that a
new extension has been installed and we have a way to list currently installed
extensions.

This patch makes TabDelegate behave the same as the other delegates
(ActionDelegate and MessageDelegate) and will allow further simplications of
the WebExtension Delegate code.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1616625 - Implement active parameter for tabs.create and update.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1eb1e65a239
Move Extension session delegates to SessionController. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/c0e05f4f2db2
Move TabDelegate to be per-WebExtension and per-GeckoSession. r=mixedpuppy,snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/b43ca6507c9a
Implement active parameter for tabs.create and update. r=mixedpuppy,snorp,esawin

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1616625) for causing xpcshell failures in xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=291526981

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291526981&repo=autoland&lineNumber=2838

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c3cd1d623f1
Backed out 3 changesets for causing xpcshell failures in xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_csp_custom_policies.js CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7772ff1517fd
Move Extension session delegates to SessionController. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/9289e0f9f2c6
Move TabDelegate to be per-WebExtension and per-GeckoSession. r=mixedpuppy,snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/0636bd0463dd
Implement active parameter for tabs.create and update. r=mixedpuppy,snorp,esawin

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Thanks.

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7772ff1517fd
https://hg.mozilla.org/mozilla-central/rev/9289e0f9f2c6
https://hg.mozilla.org/mozilla-central/rev/0636bd0463dd