1616683 - [wpt-sync] Sync PR 21887 - Clipboard API: Consistently return on detached contexts.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21887 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21887
Details from upstream follow.

Darwin Huang <[e-mail]> wrote:

Clipboard API: Consistently return on detached contexts.

Consistently fail on detached contexts. Previously, a detached context
could allow for a nullptr deref, and a renderer crash.

Consistently return nullptr for navigator.clipboard, and ensure that
a nullptr navigator.clipboard function will terminate immediately in a
consistent manner.

Also, add tests to ensure that regressions don't occur in the future.

Bug: 1028591
Change-Id: I67f8a76dc2901e7447049ff99e0b27ea6afeba63
Reviewed-on: https://chromium-review.googlesource.com/2057817
WPT-Export-Revision: 33972990359ff8b14f28872a152bd09d5578a942

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fca78a3676d5beee236f240a8a36bc5f0dbe8761

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 1
PASS: 44
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/clipboard-apis/detached-iframe/clipboard-on-detached-iframe.https.html
Verify navigator.clipboard attached only on attached frames: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0200c31dd55f
[wpt PR 21887] - Clipboard API: Consistently return on detached contexts., a=testonly
https://hg.mozilla.org/integration/autoland/rev/5ddcce840332
[wpt PR 21887] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0200c31dd55f
https://hg.mozilla.org/mozilla-central/rev/5ddcce840332