Closed Bug 1616684 Opened 2 years ago Closed 2 years ago

Remove implicit integer type conversion in CheckedInt

Categories

(Core :: MFBT, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

When I try to enable -Wconversion, CheckedInt triggers it because it has an implicit type conversion in its templated two-arg constructor.

That constructor doesn't really need to be templated, as far as I can tell.

When I try to enable -Wconversion, CheckedInt triggers it because it has an
implicit type conversion in its templated two-arg constructor.

That constructor doesn't really need to be templated, as far as I can tell.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80af7dfd0107
Remove implicit integer conversion in CheckedInt constructor r=froydnj
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.