1616705 - Add a profiler label to nsZipHandle::Init with the filename

Status: RESOLVED WONTFIX

(Core :: Gecko Profiler, task, P3)

Description

[Markus Stange [:mstange]]

nsZipHandle::Init takes up time during startup and it would be nice to know which zip file it's reading.

Profile with label: https://perfht.ml/2P5tTiD

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1616705 - Add a profiler label to nsZipHandle::Init with the filename. r=aklotz

Comment 2

[Markus Stange [:mstange]]

So the entry argument is assets/omni.ja in the case I care about, but it's not clear to me whether it usually contains a useful filename. Is there a better way to obtain the filename?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Markus Stange [:mstange]]

I don't recall the specifics but I think this profiler label wouldn't actually catch the right filename in most cases. Not worth spending more time on right now.