1616715 - Failures in 1.0.4 conformance/canvas/webgl-to-2d-canvas.html?webglVersion=1

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P1)

Description

[Kelsey Gilbert [:jgilbert]]

c2d.drawImage() doesn't handle non-premult sources.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1616715 - SurfaceFromElement gets alpha Premult unless opt-in to NonPremult.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5005fe56b7b0
SurfaceFromElement gets alpha Premult unless opt-in to NonPremult. r=lsalzman

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_2_conformance2__canvas__to-data-url-with-pack-params.html

backout: https://hg.mozilla.org/integration/autoland/rev/161fde043557b4ce32267839b006742907f68bb9

push: appeared on a subsequent push due to infra issues
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=289758628&revision=410c9a49193546899891d43d7e77ba1d40c4be1a&searchStr=m%28gl2c1%29&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289758628&repo=autoland&lineNumber=1986

[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - Buffered messages finished
[task 2020-02-20T22:51:27.723Z] 22:51:27 WARNING - 45 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-conf/generated/test_2_conformance2__canvas__to-data-url-with-pack-params.html | getError expected: NO_ERROR. Was INVALID_OPERATION : Test should not generate GL error
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:299:16
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - reportResults@dom/canvas/test/webgl-conf/mochi-single.html?checkout/conformance2/canvas/to-data-url-with-pack-params.html?webglVersion=2:22:14
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - reportTestResultsToHarness@dom/canvas/test/webgl-conf/checkout/js/js-test-pre.js:111:36
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - testFailed@dom/canvas/test/webgl-conf/checkout/js/js-test-pre.js:241:31
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - glErrorShouldBeImpl@dom/canvas/test/webgl-conf/checkout/js/webgl-test-utils.js:1685:15
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - glErrorShouldBe@dom/canvas/test/webgl-conf/checkout/js/webgl-test-utils.js:1659:10
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - @dom/canvas/test/webgl-conf/checkout/conformance2/canvas/to-data-url-with-pack-params.html?webglVersion=2:60:7
[task 2020-02-20T22:51:27.723Z] 22:51:27 WARNING - 46 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-conf/generated/test_2_conformance2__canvas__to-data-url-with-pack-params.html | getError expected: NO_ERROR. Was INVALID_OPERATION : Test should not generate GL error
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:299:16
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - reportResults@dom/canvas/test/webgl-conf/mochi-single.html?checkout/conformance2/canvas/to-data-url-with-pack-params.html?webglVersion=2:22:14
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - reportTestResultsToHarness@dom/canvas/test/webgl-conf/checkout/js/js-test-pre.js:111:36
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - testFailed@dom/canvas/test/webgl-conf/checkout/js/js-test-pre.js:241:31
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - glErrorShouldBeImpl@dom/canvas/test/webgl-conf/checkout/js/webgl-test-utils.js:1685:15
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - glErrorShouldBe@dom/canvas/test/webgl-conf/checkout/js/webgl-test-utils.js:1659:10
[task 2020-02-20T22:51:27.723Z] 22:51:27 INFO - @dom/canvas/test/webgl-conf/checkout/conformance2/canvas/to-data-url-with-pack-params.html?webglVersion=2:68:7

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1616715 - Make ReadPixelDesc per-call.

GetSurfaceSnapshot (and similar) want to ReadPixels the backbuffer,
without having to navigate the GL PIXEL_PACK state.
Since this is cold cold code, it's nice to reduce the backend state by
making ReadPixelsDesc/PixelPackState per-call, and tracked by the
client. Arguably, PIXEL_PACK_BUFFER should be per-call as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adc841b3e204
SurfaceFromElement gets alpha Premult unless opt-in to NonPremult. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/e030be1d2dd9
Make ReadPixelDesc per-call. r=lsalzman

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/adc841b3e204
https://hg.mozilla.org/mozilla-central/rev/e030be1d2dd9