1616716 - Don't use BrowserParent* in DocumentLoadListener

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Matt Woodrow (:mattwoodrow)]

We currently pass a BrowserParent for DocumentLoadListener, but for in-process <iframes> this will be the PBrowser for the top-level document. For OOP <iframes> it'll be the PBrowser for the <iframe> itself.

We use this to pass into the external helper app, which is used for finding a window to create a dialog on, and for closing if necessary.

We also use it for ParentChannelListener, and use it to implement a bunch of interfaces for remote tabs.

I think most of these would be better to use BrowsingContext* directly.

We want to be able to initiate loads with DocumentLoadListener before the content process is created, so we need to avoid depending on BrowserParent.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Don't forward ParentChannelListener QIs to BrowserParent for interfaces it doesn't implement. r?mayhemer

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Implement nsIAuthPromptProvider on ParentChannelListener. r?mayhemer

Depends on D63424

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Use BrowsingContext for most ParentChannelListener QIs. r?mayhemer

Depends on D63425

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Implement nsIRemoteWindowContext on ParentChannelListener. r?mayhemer

Depends on D63426

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Remove BrowserParent from ParentChannelListener entirely. r?mayhemer

Depends on D63427

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1616716 - Remove BrowserParent from DocumentLoadListener. r?nika

Depends on D63428

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/156d2898edb7
Don't forward ParentChannelListener QIs to BrowserParent for interfaces it doesn't implement. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/35186917e79a
Implement nsIAuthPromptProvider on ParentChannelListener. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/0174164a21e5
Use BrowsingContext for most ParentChannelListener QIs. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/a0e842d96cd6
Implement nsIRemoteWindowContext on ParentChannelListener. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/9e61658c1778
Remove BrowserParent from ParentChannelListener entirely. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/609cbe8b736e
Remove BrowserParent from DocumentLoadListener. r=nika

Comment 8

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1616716) forcausing multiple mochitest failures on test_ext_protocolHandlers.html

Backout revision https://hg.mozilla.org/integration/autoland/rev/7f41334e10443f4f1c7426e86fb0cb7adfdf4d62

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=1b4db5eb7f6f73d6b6b06956c34deab11854e12b&searchStr=mochitest

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290491655&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=609cbe8b736e8538b3bfeba4ffa3e4fb001a779e

Failure logs bc2 - https://treeherder.mozilla.org/logviewer.html#?job_id=290489124&repo=autoland
1 - https://treeherder.mozilla.org/logviewer.html#?job_id=290491687&repo=autoland

Matt can you please take a look?

Comment 9

[Cristina Coroiu [:ccoroiu]]

These failed too:
talos failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290515636&repo=autoland&lineNumber=2464
damp failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290518154&repo=autoland&lineNumber=771

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7992c5827a5f
Don't forward ParentChannelListener QIs to BrowserParent for interfaces it doesn't implement. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/3071656d0612
Implement nsIAuthPromptProvider on ParentChannelListener. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/ce7650da6340
Use BrowsingContext for most ParentChannelListener QIs. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/eb3de57b60bc
Implement nsIRemoteWindowContext on ParentChannelListener. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/ae03015ef6c8
Remove BrowserParent from ParentChannelListener entirely. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/4ba05100538e
Remove BrowserParent from DocumentLoadListener. r=nika

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7992c5827a5f
https://hg.mozilla.org/mozilla-central/rev/3071656d0612
https://hg.mozilla.org/mozilla-central/rev/ce7650da6340
https://hg.mozilla.org/mozilla-central/rev/eb3de57b60bc
https://hg.mozilla.org/mozilla-central/rev/ae03015ef6c8
https://hg.mozilla.org/mozilla-central/rev/4ba05100538e