1616753 - Global Search: Attachments type subfilters return no results; then attachments facet disappears after two clicks, making the search no-op.

Status: RESOLVED FIXED

(Thunderbird :: Search, defect, P2)

Description

[Jaise]

Attachment: Screenshot 1: Search results become no-op after attachment type subfilter fails, and Attachments facet disappears when clicked twice

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Step to produce :
step 1 search some key word.
step 2 change filter attachment to some other option
step3 click attachment collapses attachment
step4 click again attachment. it will disappear.

Actual results:

No filtering happens in 74.0b1. If select any other option documents, pdf etc and click somewhere else, from me buttons & to me buttons, total attachment option disappear as seen screen shot.
for me, other than "any kind" yield 0 results.

Comment 1

[Wayne Mery (:wsmwk)]

regression?

Comment 2

[Alessandro Castellani [:aleca]]

Might be.
I'll take care of fixing this.

Comment 3

[Jaise]

Still this bug is present in 78.11. Attachment type filtering also not working.

Comment 4

[Jaise]

Attachment: Screenshot 2: Attachments type subfilter is not working - wrongly claims no matches

subfilter is not working, actually there is lot of pdf files in this search.

Comment 5

[Alessandro Castellani [:aleca]]

I'll try to fix this later next week so we can have it for the 91 release.

Comment 6

[Thomas D. (:thomas8)]

Given that global search is currently the only search that searches attachment file names, this looks like a pretty significant failure.

STR

1. Have messages with some some test.pdf attachments (same by analogy for other file types like .jpg)
2. Global search for "test.pdf" (even "pdf", but will have more distracting results)
3. From faceted results, click Attachments (nn) facet (to show only matching messages with attachments)
   --> Attachments type subfilter appears as a closed dropdown list, set to "Any kind"
   Ensure that there are matches with pdf attachments.
4. Click the attachment types subfilter dropdown
   --> dropdown with types appears:

• Any Kind
• Documents
• Images
• PDF files

5. Choose PDF files --> No matches
6. Directly click two times on Attachments facet (in an effort to show all matches again)

Actual result

• Wrong: "No messages match your search"
• Wrong: Attachments facet shows (0)
• When clicking Attachments (0) facet two times, the entire facet disappears, and the result screen is now no-op for this search.

Expected

• Subfilter on types should work and return the correct subset of matches with count
• Attachments facet should never disappear

Comment 7

[Thomas D. (:thomas8)]

Attachment: Screencast 1: Subfilters of active Attachments facet fail, then with 2 clicks the facet goes away, and results become no-op

Here's the bug on video.

Screencast 1: Subfilters of active Attachments facet fail, then with 2 clicks the facet goes away, and results become no-op.

Comment 8

[Thomas D. (:thomas8)]

Comment on attachment 9127772 [details]
Screenshot 1: Search results become no-op after attachment type subfilter fails, and Attachments facet disappears when clicked twice

.

Comment 9

[Thomas D. (:thomas8)]

Comment on attachment 9229242 [details]
Screenshot 2: Attachments type subfilter is not working - wrongly claims no matches

.

Comment 10

[Thomas D. (:thomas8)]

Alice, you're the best when it comes to regression ranges!
If you have time, could you have a look? That would be great!
I'm assuming that this must be a regression, reported against 74.0b1.
STR in comment 6, screencast of bug in comment 7.

Comment 11

[Alice0775 White]

1st issue (Wrong: "No messages match your search"),
2nd issue (Wrong: Attachments facet shows (0)):
I can reproduce in Tb52....., It seems implementation bug.

3rd issue (When clicking Attachments (0) facet two times, the entire facet disappears...):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=af16f2eb1661589a6637131b6b81b87c4cebdeb8&tochange=7dc97f6d28a347bee552760e270dbdb254b03e7a
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b0f071e99da08c2a5b1fb406a422d8b71460e198&tochange=882200a11bcf4629de8c589f954c73bd02300645
Before , not disappears. Attachments still(0). And the dropdown shows only Any Kind.
After , disappears
This is regressed between 73 and 74...., Any way it is too old.

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: Bug 1616753 - Fix Gloda filtering when using the filterNode dropdown select. r=#thunderbird-reviewers

• Use the Gobal Search to search something.
• Click on the "Attachments" filter.
• Change the select dropdown to something else.
• CLick on the "Attachments" fiulter again.
• Ensure the filters are cleared the results page returns to the original state.

Gloda doesn't have any tests and this section will be deprecated after the Panorama database.
So this is a quick fix to remove a small annoiance that might affect users until next ESR.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7e855accc21
Fix Gloda filtering when using the filterNode dropdown select. r=tobyp