Closed Bug 1616781 Opened 4 years ago Closed 4 years ago

Clean up webconsole.css's General output styles

Categories

(DevTools :: Console, task, P3)

task

Tracking

(firefox75 fixed)

RESOLVED FIXED
Firefox 75
Tracking Status
firefox75 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

Details

Attachments

(1 file)

This section in webconsole.css could be cleaned up a bit:

/* General output styles */

a {
  -moz-user-focus: normal;
  cursor: pointer;
  text-decoration: underline;
}

/* Workaround for Bug 575675 - FindChildWithRules aRelevantLinkVisited
 * assertion when loading HTML page with links in XUL iframe */
*:visited {
}

* {
  box-sizing: border-box;
}

We probably don't need the workaround for bug 575675 anymore, and -moz-user-focus: normal looks like it may not be useful in a HTML document (might be mostly for XUL).

It might also be worth trying this:

*, ::before, ::after {
  box-sizing: border-box;
}

Let's see if we can remove this and not break stuff.

Priority: -- → P3
Assignee: nobody → florens
Status: NEW → ASSIGNED

Leaving the box-sizing part as-is because it would be hard to test all possible impacts. We may have some ::before elements with a width or height and some padding.

This leaves two rules that seem to be intended for a XUL document:

Link style

a {
  -moz-user-focus: normal;
  cursor: pointer;
  text-decoration: underline;
}

This is equivalent to default UA styles.
Tested by adding a link in the UI, and tested against the links we have in some messages (location, URLs in messages, Learn More links), everything works fine without this style.

Workaround for bug 575675

/* Workaround for Bug 575675 - FindChildWithRules aRelevantLinkVisited
 * assertion when loading HTML page with links in XUL iframe */
*:visited {
}

This was a bug where XUL documents with html|a links would throw an error if they didn't define :visited styles. The assertion itself was fixed, and the Console is not XUL anymore, so it's safe to remove.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/013ae63af9c1
Clean up old workarounds in webconsole.css; r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: