1616818 - Get rid of bool_from_str method. Use distutils.util.strtobool instead.

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Octavian Negru]

Instead of testing/raptor/raptor/manifest.py:bool_from_str, use strtobool from distutils.util

Comment 1

[Octavian Negru]

Attachment: Bug 1616818 - Get rid of bool_from_str method. Use distutils.util.strtobool instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/026538af0f95
Get rid of bool_from_str method. Use distutils.util.strtobool instead. r=perftest-reviewers,Marian,sparky

Comment 3

[Greg Mierzwinski [:sparky]]

Hmm, I don't think the patch applied properly when I tested it because I'm seeing that the ares6 and speedometer tasks are failing again on autoland: https://treeherder.mozilla.org/#/jobs?repo=autoland&tier=1%2C2%2C3&searchStr=browsertime&tochange=f449a588de9aa51bbce98437f5e125eaf901c224&fromchange=5022efe33088676d18253c3c2f86ada5ba7a9cbe

This is the error which is happening because strtobool returns 0 for False, and 1 for True:

[task 2020-02-24T15:41:02.748Z] 15:41:02     INFO -  perftest-results-handler Info: Validating PERFHERDER_DATA against /home/cltbld/tasks/task_1582555098/mozharness/external_tools/performance-artifact-schema.json
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -  perftest-results-handler Critical: Error while validating PERFHERDER_DATA
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -  perftest-results-handler Info: 1 is not of type u'boolean'
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -  Failed validating u'type' in schema[u'properties'][u'suites'][u'items'][u'properties'][u'lowerIsBetter']:
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -      {u'description': u'Whether lower values are better for suite',
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -       u'title': u'Lower is better',
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -       u'type': u'boolean'}
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -  On instance[u'suites'][0][u'lowerIsBetter']:
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -      1
[task 2020-02-24T15:41:02.752Z] 15:41:02     INFO -  perftest-results-handler Info: Writing video jobs and application data {'application': {'version': '75.0a1', 'name': 'firefox'}, 'jobs': [{'browsertime_json_path': 'browsertime-results/raptor-ares6-firefox/browsertime.json', 'test_name': 'raptor-ares6-firefox'}]} into /home/cltbld/tasks/task_1582555098/build/blobber_upload_dir/browsertime-results/jobs.json

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 026538af0f95 (Bug 1616818) on sparky's request

Backout link: https://hg.mozilla.org/integration/autoland/rev/82680b76efbe6a01c2e983bd3e78f326c4d3f61c

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/026538af0f95

Comment 6

[Cosmin Sabou [:CosminS]]

The backout in comment 4 will be included in the next round of merges to m-c.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/82680b76efbe

Comment 8

[Octavian Negru]

The result returned by strtobool must be casted to bool.
I'm changing it right now.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Why? Isn't strtobool implying that a boolean is returned? When does that not happen?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b7d49c2ff97
Get rid of bool_from_str method. Use distutils.util.strtobool instead. r=perftest-reviewers,Marian,sparky

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0b7d49c2ff97