Add tests for manifest parsing errors
Categories
(Testing :: Reftest, task, P3)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(2 files)
We currently rely on reftest-sanity to test many features of reftest's manifestparser. But since that runs as part of the normal suite, everything there needs to pass. This means we can't test the failure cases.
We should add some tests for the failure cases to reftest's python selftests.
|
Assignee | |
Comment 1•4 years ago
|
||
Adds some tests to cover error cases in reftest manifests. This is far from
comprehensive, but gives us an easy place to add more in the future.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Currently a parsing error causes reftest.jsm to hang, leaving the browser open.
Once the browser is manually closed, the Python side then emits an unrelated
traceback (since it assumes that parsing was succesful).
This ensures we both quit Firefox and check that parsing was successful (and
exit gracefully if not).
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70d1596f7beb [reftest] Exit gracefully when there is an error parsing the manifests, r=dbaron https://hg.mozilla.org/integration/autoland/rev/10d9d01b505f [reftest] Add some selftests for invalid manifests, r=dbaron
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/70d1596f7beb
https://hg.mozilla.org/mozilla-central/rev/10d9d01b505f
Description
•