1616899 - add suggestions support to built-in engines where missing

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P3)

Description

[Mike Connor [:mconnor]]

Amazon US has suggestions, but other variants do not. There are probably other plugins we should review to identify where we can add this support.

Comment 1

[Mike Kaply [:mkaply]]

eBay used to have an API:

<Url type="application/x-suggestions+json" method="GET" template="http://anywhere.ebay.com/services/suggest/">
<Param name="s" value="0"/>
<Param name="q" value="{searchTerms}"/>
</Url>

but they got rid of it.

The current search API is kind of a hack using Rover (eBay offers nothing official) and when we asked, they didn't have a replacement solution for search suggestions.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1616899 - Add search suggestions to eBay. r?mikedeboer!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/737f45e502ce
Add search suggestions to eBay. r=mikedeboer

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_eBay.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0b56ddb56d3ace7692dcc74dada092b678139c9
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305219290&repo=autoland&lineNumber=3139

Comment 5

[Mark Banner (:standard8)]

I forgot about browser_eBay.js. I'm tempted to remove those sometime seeing as we have tests in toolkit now for those. However for now, I'll just fix it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdf7aeb1e181
Add search suggestions to eBay. r=mikedeboer

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cdf7aeb1e181