161691 - Almost-standards mode doesn't use quirks layout in all cases

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Eric A. Meyer (dead account)]

The "almost standards" mode (see bug 153032) is failing in cases where table
cells have multiple <br>-separated images.  In quirks mode, the layout is the
same as NN4.x and IE/*.  In strict mode, the images spread apart, as expected. 
In almost standards mode, the images spread apart, which is not expected.  This
is demonstrated in the following three testcases (they're all linked to each other):

http://www.meyerweb.com/eric/css/tests/almost-standards.html
http://www.meyerweb.com/eric/css/tests/almost-standards-quirk.html
http://www.meyerweb.com/eric/css/tests/almost-standards-strict.html

In quirks mode, the <br> elements seem to overcome the whitespace separating the
images and thus smash the images together, which is the classic "images have to
be followed by a <br> element to close up space" behavior, circa 1996.  This
isn't carried forward to "almost standards."

The expected result, from an author's point of view, is that the layout of the
almost-standards page and the quirks page (above) would be the same.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

The quirky BR behavior that is part of the quirks mode inline box model was
still keying off the modes so that it was doing the standards mode behavior in
AlmostStandards mode.  This patch changes it so that the quirky BR behavior is
also quirky in AlmostStandards mode, which I agree is the right thing to do.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

slightly revised

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

slightly revised

Comment 4

[Eric A. Meyer (dead account)]

Marking topembed, although with the amazingly speedy patching I almost feel like
it isn't necessary.  You rock, David!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 94470 [details] [diff] [review]
patch

sr=bzbarsky

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 94470 [details] [diff] [review]
patch

r=caillon

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2002-08-11 11:00 PDT.

Comment 8

[Eric A. Meyer (dead account)]

Verifying fix in 2002081208-trunk.  Great work!

Comment 9

[Jaime Rodriguez, Jr.]

From email from Evangelist, this sounds like "a simple fix, self-contained",
that would prevent sites to be broken in the future, by not "further fragment
the DOCTYPE switching space." This has baked for 3 weeks, with no known
regressions on the trunk. Adding edt1.0.2 and Mozilla1.0.2 keywords to nominate
for 1.0 branch landing.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 94470 [details] [diff] [review]
patch

a=[e-mail] for 1.0 branch.  You know the drill.  Check in asap if you
want to make 1.0.2

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_0_BRANCH, 2002-09-11 13:14 PDT.

Comment 12

[Susie Wyshak]

Jaime please + the topembed

Comment 13

[Gayatri Rimola]

Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2 

Comment 14

[Jaime Rodriguez, Jr.]

susie: i could plus it, but it appears to already be checked in on the trunk and
1.0 branch. i will give it a posthumus edt1.0.2+ and topembed+ for you.

ian, as assigned QA Contact, can you pls verify this as fixed on the 1.0 branch?
Once verified, change the keyword "fixed1.0.2" to "verified1.0.2."

Comment 15

[Hixie (not reading bugmail)]

I don't have a branch build and do not have the time to concentrate on anything
apart from the trunk, sorry.

Comment 16

[Jaime Rodriguez, Jr.]

Thanks for the feedback Ian.

Bob/Susie: Is this something the evangelist can verify?

Comment 17

[Madhur Bhatia]

verified fixed on branch :
checked on -- win2000 ----- 2002-10-03-08-1.0 build
           -- linux 7.2 --- 2002-10-03-07-1.0 build

changing KW  from fixed1.0.2 to verified1.0.2