1616925 - Support git+ssh with ssh keys for fetch jobs

Status: REOPENED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

The ssh key will come from a taskcluster secret...

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Got this working in holly here: https://treeherder.mozilla.org/#/jobs?repo=holly&revision=ea1bab9e48e22978bab7a3f1bf3abd2c14858c6c

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1616925 - Support a taskcluster-based ssh key for fetch jobs r?tomprince

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/359f9a3acc75
Support a taskcluster-based ssh key for fetch jobs r=tomprince

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 359f9a3acc75 (Bug 1616925) for causing failures in test_2_conformance2__glsl3__matrix-row-major-dynamic-indexing.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Wk5ypumaSZeG7PAuNpFDhQ.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-webgl2-ext-e10s%2Cgl2e1&tochange=d60e98d8b00d31277a935e6c96b775dd3dcf2255&fromchange=11f0f54c6e0a641470e6fba29733b3ab764df3ef

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311914149&repo=autoland&lineNumber=1695

Backout: https://hg.mozilla.org/integration/autoland/rev/e1cfb4c47f2c7a080458e0a1b71cd17751a8bfeb

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

It looks like I might be being affected by a similar issue as the one in Bug 1648851 where previously failing tests are not passing for inexplicable reasons unrelated to the actual patch at hand. At least that's my interpretation on this... Joel was that the conclusion that was arrived at in 1648851? I see that eventually a subsequent patch was written to just mark the tests as now passing....

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

typically any system change has the chance of affect a small number of tests. if it is <20 tests, I spend a few minutes asking around and trying a few fixes- otherwise what isn't straightforward is adjusted. In many cases it is something like a small graphics change or cpu timing changes due to optimizations or more processes slowing down the system.

If a test is now passing that is good. There are scenarios where a passing test isn't good- in the case where it does nothing or cannot display everything, but the checks are written to not account for that. I would ensure the test is doing what it should be doing and mark it as passing, that is a win!

For this test if you do edit the manifest, you need to edit:
dom/canvas/test/webgl-conf/mochitest-errata.ini

then run:
python dom/canvas/test/webgl-conf/generate-wrappers-and-manifest.py

that will edit the mochitest.ini file and you need to commit the change to both mochitest-errata.ini and mochitest.ini :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5833cd81a80c
Support a taskcluster-based ssh key for fetch jobs r=tomprince

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5833cd81a80c