1616967 - Bookmark All Tabs does not bookmark all tabs.

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, enhancement)

Description

[Patrick]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Bookmark all tabs with multiple copies of the same site spread throughout the open tabs. Any duplicate tabs will only be bookmarked on the first instance of that tab and subsequent copies will be silently ignored.

Actual results:

If the open tabs when Bookmark All Tabs is clicked are (A, B, C, D, A, C, E, F, D) the duplicates are ignored such that the bookmark all tabs will result in a bookmark folder with (A, B, C, D, E, F) in it. This regression was introduced sometime after Firefox 57, although I can not pinpoint exactly when this change occured.

Expected results:

Bookmark ALL Tabs should bookmark ALL tabs. The result from the above example should be (A, B, C, D, A, C, E, F, D) not (A, B, C, D, E, F). Optional a config option to control this behavior because I am sure that some people prefer it this way, while I fully detest this manner of action.

Comment 1

[Patrick]

The bug is also present on Firefox 72.0.2 on Linux Mint 19.1. (Mint version 1.0 is also listed in the firefox about dialog)

Comment 2

[Daniel Bodea [:danibodea]]

I have confirmed this issue, but I do not know whether it is intended or not. This being said, I have set it's component as (Firefox) Bookmarks and History and set it as an enhancement.

Thank you for your contribution!

Comment 3

[Marco Bonardo [:mak]]

The behavior is actually intended, bookmarks are not a way to store a tabs session, there are other better ways to do that, and add-ons.
I'm sorry but we don't plan to change this behavior at the moment, and in general we don't add options unless there is a large group of users depending on a behavior, or that behavior is otherwise impossible.

Comment 4

[Patrick]

Perhaps updating the option to a more accurate description of "bookmark most tabs" as the bookmark all tabs feature was changed to this. At the very least an option to maintain past functionality would have been nice.

Comment 5

[Marco Bonardo [:mak]]

The text must be short and easy to comprehend for most users, not necessarily perfect.
Using "most" would be even worse, because then one would guess what "most" means in that context, it wouldn't add any specific more details than "all".
This is just a design choice, we preferred to discard duplicates, and we have no strong reasons to change that, bookmarks are not intended to store tabs state.