Closed Bug 1617138 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21919 - Align <pattern> and <*Gradient> attribute collection

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21919
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Align <pattern> and <*Gradient> attribute collection

The difference now is that we stop collection of the pattern attributes
if one of the \<pattern>s that is inherited from is not in the layout
tree (but still use the result). For gradients this cause the generation
of the paint server to fail.
Make attribute collection return false in the same way for \<pattern>
and \<*Gradient>.

Add const qualification to the CollectGradientAttributes() methods.

Bug: 109212

Change-Id: Ie8a22664c4dc37ebc10fb02f18e1176a9d41a0e0
Reviewed-on: https://chromium-review.googlesource.com/968924
WPT-Export-Revision: ed6d903e297aa7c0ad3416dd46a46ef476c19b1c

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d311cf519c8d
[wpt PR 21919] - Align <pattern> and <*Gradient> attribute collection, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d311cf519c8d

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.