If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

stop exporting nsStr

RESOLVED FIXED in mozilla1.2alpha

Status

()

Core
String
P3
normal
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Trunk
mozilla1.2alpha
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
we're exporting nsStr which means that occasional libraries are picking up
random routines from it, and there is really no need - for instance, Layout is
importing nsStr::GetCharSize() because it is calling the global GetCharAt(),
which should also not be exported.

patch forthcoming.
(Assignee)

Comment 1

15 years ago
Created attachment 94480 [details] [diff] [review]
stop exporting nsStr

this stops exporting nsStr, and fixes the one caller who was importing it
inadvertently.
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2alpha

Comment 2

15 years ago
Comment on attachment 94480 [details] [diff] [review]
stop exporting nsStr

looks great. r=dougt
Attachment #94480 - Flags: review+

Comment 3

15 years ago
Comment on attachment 94480 [details] [diff] [review]
stop exporting nsStr

sr=jag
Attachment #94480 - Flags: superreview+
(Assignee)

Comment 4

15 years ago
fix went in recently.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.