[wpt-sync] Sync PR 21920 - [PerformanceObserver] Fix observe() edge cases
Categories
(Core :: Performance, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 21920 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/21920
Details from upstream follow.
Nicolás Peña Moreno <npm@chromium.org> wrote:
[PerformanceObserver] Fix observe() edge cases
Currently, two calls to observe with the same 'type' will result in a
console error, whereas the spec implies that this is valid, with the
later call overriding the initial one. This CL fixes that. It also fixes
a problem where disconnect would not clear the filter_options_, as shown
in https://github.com/w3c/performance-timeline/pull/161. This would not
be a problem with 'entryTypes' because this variable would be replaced
on every call to observe(). Tests are added for these two cases.Bug: 1052509
Change-Id: I75865b2925e2fb1a7e7fd64d7e979907c3b7650c
Reviewed-on: https://chromium-review.googlesource.com/2067250
WPT-Export-Revision: 3c514f3f55172429f3b80b28da20e52dfda5c463
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c5fe58123770e5e98e597a120517b1dc127428a
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 4 tests and 1 subtests
Status Summary
Firefox
OK : 2
FAIL : 2
TIMEOUT: 4
Chrome
OK : 2
FAIL : 2
TIMEOUT: 4
Safari
OK : 4
FAIL : 4
Links
Details
New Tests That Don't Pass
/performance-timeline/po-observe-repeated-type.any.html: TIMEOUT (Chrome: TIMEOUT, Safari: OK)
Two calls of observe() with the same 'type' cause override.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
/performance-timeline/po-observe-repeated-type.any.worker.html: TIMEOUT (Chrome: TIMEOUT, Safari: OK)
Two calls of observe() with the same 'type' cause override.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
/performance-timeline/po-disconnect-removes-observed-types.any.worker.html
Types observed are forgotten when disconnect() is called.: FAIL (Chrome: FAIL, Safari: FAIL)
/performance-timeline/po-disconnect-removes-observed-types.any.html
Types observed are forgotten when disconnect() is called.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f11384e143a [wpt PR 21920] - [PerformanceObserver] Fix observe() edge cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/b5acc785acd2 [wpt PR 21920] - Update wpt metadata, a=testonly
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f11384e143a
https://hg.mozilla.org/mozilla-central/rev/b5acc785acd2
Description
•