1617234 - Glean deletion ping in Lockwise-Android is seeing an error in schema rejection

Status: RESOLVED INCOMPLETE

(Data Platform and Tools :: Glean: SDK, defect, P3)

Description

[Travis Long [:travis_]]

See the schema rejection query.

The deletion_request ping is seeing a lot of schema rejections due to the error: https://console.cloud.google.com/bigquery?project=moz-fx-data-shared-prod&j=bq:US:bquxjob_5bce6115_17068c9af76&page=queryresults

Is this due to the underscore?

Comment 1

[Jeff Klukas [:klukas] (UTC-4)]

No, the pipeline is tolerating the underscore. It looks like these rejected deletion_request pings all contain the canary client_id c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0. We recently put in a change in the decoder to catch that value and throw a AffectedByBugException to route to errors.

Comment 2

[Jan-Erik Rediger [:janerik]]

lockwise-android is currently using android-components 27.0.4 which bundles Glean v22.1.0
I started to write another test (after I recently already added one) to track down why we see so many c0ffee deletion-request pings.
That exposed the bug in that we sent deletion-request pings when re-setting uploadEnabled to false several times.
I then backported the above linked test and it also fails (so it is testing what it should be).

We used to submit pings always without an upload-enabled check. That was fixed in #575, which was included in v23.0.0
The other linked PR enforced this even further for deletion-request pings to only submit if uploadEnabled changes to false.

The solution for lockwise-android: Upgrade the android-components version to upgrade Glean.
:travis_, can you forward that suggestion and track it?

I also un-take this bug as there's nothing further to do for me here.

Comment 3

[Travis Long [:travis_]]

:travis_, can you forward that suggestion and track it?

I've already asked them to upgrade to get the fixes for the baseline ping, so I'm waiting to hear back from them about the timeframe in which they can do this. The blocker is that there are some breaking changes in A-C that they will need to deal with also. I'll go ahead and file an issue on their GitHub (if there isn't one already) and link to it here.

Comment 4

[Travis Long [:travis_]]

Adding a bug dependency on the bug that is tracking Lockwise-Android updating their version of A-C, and thus Glean. Also, changing this to P3 since we don't really have a timeframe on when they will update yet.

Comment 5

[Travis Long [:travis_]]

Closing this as INCOMPLETE due to the fact that Lockwise will likely not update and the fact that the bug that this depended on was also closed as INCOMPLETE.