Closed Bug 1617256 Opened 1 month ago Closed 1 month ago

Remove two unused safe browsing error codes

Categories

(Toolkit :: Safe Browsing, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

These were added in bug 1461515.

Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39cc23a7483c
Remove the unused NS_ERROR_MAYBE_TRACKING_URI and NS_ERROR_TRACKING_ANNOTATION_URI error codes; r=dimi

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-junit-e10s%2C%28gv-junit%29&revision=39cc23a7483ce4f73ac20e195b7cbd3f7d49851e&selectedJob=289955456

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=289955456&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e64a6873ff1bf6dc89c8f107af8801a7ab3ffdf

[task 2020-02-21T21:06:03.740Z] 21:06:03     INFO -  TEST-START | org.mozilla.geckoview.test.NavigationDelegateTest.safebrowsingHarmful
[task 2020-02-21T21:06:03.841Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=640
[task 2020-02-21T21:06:03.841Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2020-02-21T21:06:03.841Z] 21:06:03     INFO -  org.mozilla.geckoview.test | Error in safebrowsingHarmful(org.mozilla.geckoview.test.NavigationDelegateTest):
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | java.lang.AssertionError: Error code should match
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | Expected: <71>
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test |      but: was <17>
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.Assert.assertThat(Assert.java:956)
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
[task 2020-02-21T21:06:03.842Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:801)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:81)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest$testLoadErrorWithErrorPage$1.onLoadError(NavigationDelegateTest.kt:59)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$1.invoke(GeckoSessionTestRule.java:1060)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Proxy.invoke(Proxy.java:813)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at $Proxy22.onLoadError(Unknown Source)
[task 2020-02-21T21:06:03.846Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:594)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:507)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:90)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.util.UiThreadUtils.waitForCondition(UiThreadUtils.java:155)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitUntilCalled(GeckoSessionTestRule.java:1556)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStops(GeckoSessionTestRule.java:1355)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStop(GeckoSessionTestRule.java:1330)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStop(GeckoSessionTestRule.java:1320)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.testLoadErrorWithErrorPage(NavigationDelegateTest.kt:71)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.testLoadExpectError(NavigationDelegateTest.kt:92)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.safebrowsingHarmful(NavigationDelegateTest.kt:469)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0$GeckoSessionTestRule$2(GeckoSessionTestRule.java:1282)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.-$$Lambda$GeckoSessionTestRule$2$sIbRNaZJgAu-QrUVWSGD8JbPSWM.run(lambda)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Looper.loop(Looper.java:154)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2020-02-21T21:06:03.847Z] 21:06:03     INFO -  org.mozilla.geckoview.test |
[task 2020-02-21T21:06:03.943Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=safebrowsingHarmful
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.NavigationDelegateTest
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stack=java.lang.AssertionError: Error code should match
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | Expected: <71>
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test |      but: was <17>
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.Assert.assertThat(Assert.java:956)
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
[task 2020-02-21T21:06:03.944Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:801)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:81)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest$testLoadErrorWithErrorPage$1.onLoadError(NavigationDelegateTest.kt:59)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.957Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$1.invoke(GeckoSessionTestRule.java:1060)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Proxy.invoke(Proxy.java:813)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at $Proxy22.onLoadError(Unknown Source)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:594)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:507)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:90)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.util.UiThreadUtils.waitForCondition(UiThreadUtils.java:155)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitUntilCalled(GeckoSessionTestRule.java:1556)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStops(GeckoSessionTestRule.java:1355)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStop(GeckoSessionTestRule.java:1330)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.waitForPageStop(GeckoSessionTestRule.java:1320)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.testLoadErrorWithErrorPage(NavigationDelegateTest.kt:71)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.testLoadExpectError(NavigationDelegateTest.kt:92)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.NavigationDelegateTest.safebrowsingHarmful(NavigationDelegateTest.kt:469)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0$GeckoSessionTestRule$2(GeckoSessionTestRule.java:1282)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.-$$Lambda$GeckoSessionTestRule$2$sIbRNaZJgAu-QrUVWSGD8JbPSWM.run(lambda)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.os.Looper.loop(Looper.java:154)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at java.lang.reflect.Method.invoke(Native Method)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test |
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=329
[task 2020-02-21T21:06:03.961Z] 21:06:03     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: -2
[task 2020-02-21T21:06:03.961Z] 21:06:03  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.NavigationDelegateTest.safebrowsingHarmful | java.lang.AssertionError: Error code should match
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9011d5fe7e84
Remove the unused NS_ERROR_MAYBE_TRACKING_URI and NS_ERROR_TRACKING_ANNOTATION_URI error codes; r=dimi
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Flags: needinfo?(ehsan)
You need to log in before you can comment on or make changes to this bug.