1617315 - Add crashtest for Assertion failure: !aParam.GetMaybeDiscarded() || aParam.GetMaybeDiscarded()->EverAttached(), at src/docshell/base/BrowsingContext.cpp:1525

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Reduced with m-c 20200221-b72f6888ad96

Assertion failure: !aParam.GetMaybeDiscarded() || aParam.GetMaybeDiscarded()->EverAttached(), at src/docshell/base/BrowsingContext.cpp:1525

#0 0x7fcdf09b48c7 in mozilla::ipc::IPDLParamTraits<mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> >::Write(IPC::Message*, mozilla::ipc::IProtocol*, mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&) src/docshell/base/BrowsingContext.cpp:1524:3
#1 0x7fcde6cb0a23 in mozilla::dom::PContentChild::SendCommitBrowsingContextTransaction(mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&, mozilla::dom::syncedcontext::Transaction<mozilla::dom::BrowsingContext> const&, unsigned long const&) src/obj-firefox/ipc/ipdl/PContentChild.cpp:7304:5
#2 0x7fcdf0998b8a in mozilla::dom::BrowsingContext::SendCommitTransaction(mozilla::dom::ContentChild*, mozilla::dom::syncedcontext::Transaction<mozilla::dom::BrowsingContext> const&, unsigned long) src/docshell/base/BrowsingContext.cpp:1256:11
#3 0x7fcdf0998393 in mozilla::dom::syncedcontext::Transaction<mozilla::dom::BrowsingContext>::Commit(mozilla::dom::BrowsingContext*) src/obj-firefox/dist/include/mozilla/dom/SyncedContextInlines.h:41:13
#4 0x7fcde9897ff1 in void mozilla::dom::BrowsingContext::SetSandboxFlags<unsigned int&>(unsigned int&) src/obj-firefox/dist/include/mozilla/dom/BrowsingContext.h:129:3
#5 0x7fcde98904cf in nsFrameLoader::ApplySandboxFlags(unsigned int) src/dom/base/nsFrameLoader.cpp:3084:21
#6 0x7fcdebada571 in mozilla::dom::HTMLIFrameElement::AfterSetAttr(int, nsAtom*, nsAttrValue const*, nsAttrValue const*, nsIPrincipal*, bool) src/dom/html/HTMLIFrameElement.cpp:170:23
#7 0x7fcde9647c84 in mozilla::dom::Element::SetAttrAndNotify(int, nsAtom*, nsAtom*, nsAttrValue const*, nsAttrValue&, nsIPrincipal*, unsigned char, bool, bool, bool, mozilla::dom::Document*, mozAutoDocUpdate const&) src/dom/base/Element.cpp:2353:10
#8 0x7fcde9641bac in mozilla::dom::Element::SetAttr(int, nsAtom*, nsAtom*, nsTSubstring<char16_t> const&, nsIPrincipal*, bool) src/dom/base/Element.cpp:2213:10
#9 0x7fcde964154b in mozilla::dom::Element::SetAttribute(nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsIPrincipal*, mozilla::ErrorResult&) src/dom/base/Element.cpp:1285:12
#10 0x7fcdeaddd28e in mozilla::dom::Element_Binding::setAttribute(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) src/obj-firefox/dom/bindings/ElementBinding.cpp:1305:24
#11 0x7fcdeb1f2c98 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) src/dom/bindings/BindingUtils.cpp:3170:13
#12 0x7fcdf16bb343 in CallJSNative src/js/src/vm/Interpreter.cpp:477:13
#13 0x7fcdf16bb343 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:569:12
#14 0x7fcdf16bd13a in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:632:10
#15 0x7fcdf16a1c65 in CallFromStack src/js/src/vm/Interpreter.cpp:636:10
#16 0x7fcdf16a1c65 in Interpret(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:3049:16
#17 0x7fcdf1685261 in js::RunScript(JSContext*, js::RunState&) src/js/src/vm/Interpreter.cpp:449:10
#18 0x7fcdf16bb425 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) src/js/src/vm/Interpreter.cpp:604:13
#19 0x7fcdf16bd13a in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) src/js/src/vm/Interpreter.cpp:632:10
#20 0x7fcdf16bd416 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) src/js/src/vm/Interpreter.cpp:649:8
#21 0x7fcdf18544b2 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) src/js/src/jsapi.cpp:2797:10
#22 0x7fcdeae0bfb0 in mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) src/obj-firefox/dom/bindings/EventListenerBinding.cpp:52:8
#23 0x7fcdeb8b884b in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) src/obj-firefox/dist/include/mozilla/dom/EventListenerBinding.h:66:12
#24 0x7fcdeb8b8284 in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) src/dom/events/EventListenerManager.cpp:1073:43
#25 0x7fcdeb8b98e6 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) src/dom/events/EventListenerManager.cpp:1271:17
#26 0x7fcdeb8a75cf in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:356:17
#27 0x7fcdeb8a5b21 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) src/dom/events/EventDispatcher.cpp:558:16
#28 0x7fcdeb8aa5db in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) src/dom/events/EventDispatcher.cpp:1055:11
#29 0x7fcdeb8af549 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsPresContext*, nsEventStatus*) src/dom/events/EventDispatcher.cpp
#30 0x7fcde98b23de in nsINode::DispatchEvent(mozilla::dom::Event&, mozilla::dom::CallerType, mozilla::ErrorResult&) src/dom/base/nsINode.cpp:1269:17
#31 0x7fcde9310bc7 in nsContentUtils::DispatchEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, mozilla::Trusted, bool*, mozilla::ChromeOnlyDispatch) src/dom/base/nsContentUtils.cpp:4077:28
#32 0x7fcde9310903 in nsContentUtils::DispatchTrustedEvent(mozilla::dom::Document*, nsISupports*, nsTSubstring<char16_t> const&, mozilla::CanBubble, mozilla::Cancelable, mozilla::Composed, bool*) src/dom/base/nsContentUtils.cpp:4047:10
#33 0x7fcde95d5305 in mozilla::dom::Document::DispatchContentLoadedEvents() src/dom/base/Document.cpp:7249:3
#34 0x7fcde96a1d74 in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> src/obj-firefox/dist/include/nsThreadUtils.h:1160:12
#35 0x7fcde96a1d74 in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> src/obj-firefox/dist/include/nsThreadUtils.h:1166:12
#36 0x7fcde96a1d74 in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() src/obj-firefox/dist/include/nsThreadUtils.h:1212:13
#37 0x7fcde564f85d in mozilla::SchedulerGroup::Runnable::Run() src/xpcom/threads/SchedulerGroup.cpp:282:20
#38 0x7fcde5683ff8 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1220:14
#39 0x7fcde568ee5c in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:481:10
#40 0x7fcde68eb4df in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:87:21
#41 0x7fcde67de9e7 in RunInternal src/ipc/chromium/src/base/message_loop.cc:315:10
#42 0x7fcde67de9e7 in RunHandler src/ipc/chromium/src/base/message_loop.cc:308:3
#43 0x7fcde67de9e7 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:290:3
#44 0x7fcded92b4c8 in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:137:27
#45 0x7fcdf1455496 in XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:943:20
#46 0x7fcde67de9e7 in RunInternal src/ipc/chromium/src/base/message_loop.cc:315:10
#47 0x7fcde67de9e7 in RunHandler src/ipc/chromium/src/base/message_loop.cc:308:3
#48 0x7fcde67de9e7 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:290:3
#49 0x7fcdf1454ae0 in XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:778:34
#50 0x55a37c284433 in content_process_main src/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28
#51 0x55a37c284433 in main src/browser/app/nsBrowserApp.cpp:303:18

Comment 1

[Chris Peterson [:cpeterson]]

Nika says this bug was likely fixed by bug 1615480.

We should add this test as a crashtest.

M5

Comment 2

[Chris Peterson [:cpeterson]]

Assigning to kmag

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1617315. Add crashtest.

Depends on D65880

Comment 4

[Timothy Nikkel (:tnikkel)]

Landing the crashtest, not sure if kmag wants to do more with this bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0af13c21d290
Add crashtest.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0af13c21d290

Comment 7

[Chris Peterson [:cpeterson]]

Moving P2 M5 bugs to M5b milestone