Closed Bug 1617318 Opened 4 years ago Closed 4 years ago

When a tip is shown, automatically increment the <type>-shown key in the urlbar.tips keyed scalar telemetry

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement
Points:
2

Tracking

()

RESOLVED WONTFIX

People

(Reporter: adw, Unassigned)

References

Details

For the urlbar.tips keyed scalar telemetry, UrlbarInput automatically increments the keys <type>-picked and <type>-help, where <type> is the tip's payload.type. By "automatically" I mean that it's done in one place and each provider doesn't have to do it.

But currently the search tips and interventions providers each increment their <type>-shown. It would be nice if <type>-shown were instead incremented automatically too. UrlbarView seems like an obvious place. The muxer is another possibility.

For tests, currently the search tips and interventions tests each check their <type>-shown telemetry. We should keep that, but we should also add a generic tips test that checks it. Currently we only have two generic tips tests, browser_tip_selection.js and browser_tip_picks.js (added in bug 1608461). browser_tip_picks.js checks <type>-picked and <type>-help telemetry. We could expand it slightly to also check <type>-shown. Or we could add a new file.

See Also: → 1616752

Actually... Interventions require special handling for the shown scalar because we want to increment it only once per engagement, not each time an intervention appears in the view. So that only leaves search tips that would benefit from this, and there's no reason to do this for only search tips. If we add more types of tips in the future where we want to increment the shown scalar each time they're shown, then we can come back to this, but right now it's not useful, so I'll close it.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
See Also: → 1618115
See Also: → 1676250
You need to log in before you can comment on or make changes to this bug.