1617406 - comm/mail/test/browser/composition/browser_imageInsertionDialog.js | Uncaught exception - at resource://testing-common/mozmill/utils.jsm:386 - TimeoutError: Timeout waiting for modal dialog to open.

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=290035215&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LvYxF2YcQHWpt6cD2nA5lQ/runs/0/artifacts/public/logs/live_backing.log

---

Fails locally too

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: 1617406-image-insertion.diff

Does the job.

Comment 2

[Jorg K (CEST = GMT+2)]

Why does the name matter now? The original code suggests that it didn't matter: input_value(mwc, "whateverItDoesntMatterAnyway.png");

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9128362 [details] [diff] [review]
1617406-image-insertion.diff

Review of attachment 9128362 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work. r=mkmelin
I'm too curious why it works.

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

https://hg.mozilla.org/mozilla-central/rev/76472c6d442738730a601ecf22d6cd83e570cae2 made it matter.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f0bba3048c1
Use a real image in image insertion test. r=mkmelin

Comment 6

[Intermittent Failures Robot]

19 failures in 4045 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 19

Platform breakdown:

• linux64: 4
• macosx1014-64: 3
• linux32: 1
• windows7-32: 3
• windows10-64: 3
• linux32-shippable: 1
• linux64-shippable: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617406&startday=2020-02-17&endday=2020-02-23&tree=all

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks. It could be helpful to state such things and also include them in the commit message, like in "Use a real image in image insertion test after bug 1616537".

Comment 8

[Magnus Melin [:mkmelin]]

Reminds me of a talk from FOSDEM: "I can read the code so see what it's doing. The commit message should say why."