1617448 - browser.compose.beginNew needs a way of specifying the identity to use

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Mark Banner (:standard8)]

In Conversations we offer a button that allows starting an email directly to a contact from within the message header.

If I use browser.compose.beginNew, then I have no option to specify that it should use a particular account / identity / email address to use.

This means that any time a user opens a compose window with this method, they'll be defaulted to the default identity, even though they're on a different account.

This probably depends on some of the work in bug 1531593.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1617448-part1-rename-composeparams-1.diff

This just renames a variable because it's confusing.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1617448-part2-compose-identities-1.diff

This is the actual change.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9137048 [details] [diff] [review]
1617448-part2-compose-identities-1.diff

Review of attachment 9137048 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/extensions/parent/ext-compose.js
@@ +173,5 @@
>      plainTextBody: editor.outputToString("text/plain", 0),
>    };
> +  if (extension.hasPermission("accountsRead")) {
> +    details.identityId = composeWindow.getCurrentIdentityKey();
> +  }

Maybe permission checks should be on top?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b2b96ec63aff
Rename composeParams variable to details to avoid confusion. r=mkmelin
https://hg.mozilla.org/comm-central/rev/83b898e3dfb2
Allow the compose APIs to work with identities. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ccfc0f0d776c
follow-up - Remove some incorrect text from the compose API documentation. rs=docs-only DONTBUILD