1617454 - Remove the unused prefwindow-dlgbuttons and dialog-button classes

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The prefwindow-dlgbuttons and dialog-button classes are either no more used or in shadow-root and thus not accessible for our CSS.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1617454-remove-dialog-rules.patch

This removes the classes and also removes double empty lines in the sanitizeDialog.css.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9128380 [details] [diff] [review]
1617454-remove-dialog-rules.patch

Review of attachment 9128380 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f08e737dee01
Remove the unused prefwindow-dlgbuttons and dialog-button classes. r=mkmelin DONTBUILD

Comment 4

[vtol]

Attachment: mozreg.png

• W10 x64
• TB 74.0b2 (64-bit)
• TB 75 | 76

---

Trying to migrate account and mail folders from TB 74 TB 75 | 76 but both 75 & 76 silently crashing on start, no crash logs in AppData\Roaming\Thunderbird\Crash Reports

What I did:

1. made a copy of the profile folder from the TB74 instance and renamed it
2. started the 75 | 76 daily instance with -p, created a new profile and pointed to that copied profile folder

also tried:

3. started 75 | 76 and created a new profile with a new folder
4. closed 75 | 76 and copied the content from the 74 instance profile folder

but the 75 | 76 instance just keeps on silently crashing. Also tried with the -migrate handle but same outcome. As last resort ran Mozregression which points to this bug as potential cause.

Comment 5

[Richard Marti (:Paenglab)]

It's very unlikely that removed margin rules from not existent elements cause a crash. Have you checked the mozilla-central changes in this time frame?