1617461 - messageDisplay APIs don't take account of multiple message selection

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Mark Banner (:standard8)]

Selecting multiple messages is a possibility in Thunderbird and Thunderbird displays the summary for them, however the messageDisplay APIs only take account of a single message being displayed.

Comment 1

[Mark Banner (:standard8)]

I'm part way through a patch for this. I'll be creating two new APIs - getDisplayedMessages and onMessagesDisplayed. I don't think it makes sense to try and work this into the existing APIs, since the returned values would be fundamentally different.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1617461 - Reorganise browser_ext_messageDisplay.js to make it simpler and clearer. r?darktrojan!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1617461 - Add apis for getting and receiving events when single and multiple messages are selected. r?darktrojan!

Depends on D84925

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2c98bae7c64e
Reorganise browser_ext_messageDisplay.js to make it simpler and clearer. r=darktrojan
https://hg.mozilla.org/comm-central/rev/7a23c935ef44
Add apis for getting and receiving events when single and multiple messages are selected. r=darktrojan

Comment 5

[Magnus Melin [:mkmelin]]

Uplift to 78?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b8c06a3eace
follow-up - Fix schema files to match documentation. rs=docs-only

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9166141 [details]
Bug 1617461 - Add apis for getting and receiving events when single and multiple messages are selected. r?darktrojan!

[Approval Request Comment]
WX api correctness fixes, have baked for a while already.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9166141 [details]
Bug 1617461 - Add apis for getting and receiving events when single and multiple messages are selected. r?darktrojan!

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/f3a367609d5c
https://hg.mozilla.org/releases/comm-esr78/rev/f09df7bdea3b
https://hg.mozilla.org/releases/comm-esr78/rev/f0533b32b3b4

Comment 10

[Rob Lemley [:rjl]]

Backout 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/ab7d41cf420f

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/7211f289df3f
https://hg.mozilla.org/releases/comm-esr78/rev/5acc8ef880cd

Comment 12

[John Bieling (:TbSync)]

Hm, it looks like
https://hg.mozilla.org/comm-central/rev/4b8c06a3eace
was backed out but never made it back in?

Comment 13

[Rob Lemley [:rjl]]

Yeah, looks like it...

Background info... After the massive failure building 78.3.2 that led to the backout, Geoff made a mercurial bundle for me with the MailExtension API changes that would going into 78.4.0. That bundle file only had two of the three commits from this bug apprentley and it went unnoticed.

Per our conversation in Matrix, I'll uplift it now since it only affects documentation so that you're not blocked on the mailextension docs work.

Comment 14

[Rob Lemley [:rjl]]

Previously missed uplift, documentation only.

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/e755d66418c5