1617546 - mozilla::Nothing should provide an operator==

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Simon Giesecke [:sg] [he/him]]

To be able to use mozilla::Nothing within mozilla::Variant and then be able to use mozilla::Variant::operator==, mozilla::Nothing should provide

inline constexpr bool operator==(const Nothing&, const Nothing&) {
  return true;
}

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1617546 - Provide operator== for mozilla::Nothing. r=froydnj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b76a3aa5ff6f
Provide operator== for mozilla::Nothing. r=froydnj

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=busted%2Cexception&fromchange=cb38779e1eb6610ecb6ceeddd496841a30988136&selectedJob=290220436

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=290220436&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/8e64763e531fde29c56d951c24c7363c2c844b95

[task 2020-02-24T17:44:06.869Z] 17:44:06     INFO -  z:/build/build/src/obj-firefox/dist/include/mozilla/RefPtr.h(289,3): note: candidate function
[task 2020-02-24T17:44:06.869Z] 17:44:06     INFO -    operator T*() const&
[task 2020-02-24T17:44:06.869Z] 17:44:06     INFO -    ^
[task 2020-02-24T17:44:06.869Z] 17:44:06     INFO -  z:/build/build/src/obj-firefox/dist/include/mozilla/RefPtr.h(305,3): note: candidate function
[task 2020-02-24T17:44:06.869Z] 17:44:06     INFO -    operator T*() const&& = delete;
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -    ^
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -  z:/build/build/src/ipc/mscom/Interceptor.cpp(50,61): note: passing argument to parameter 'aValue' here
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -    void Put(IUnknown* aKey, already_AddRefed<IWeakReference> aValue) {
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -                                                              ^
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -  2 errors generated.
[task 2020-02-24T17:44:06.870Z] 17:44:06     INFO -  z:/build/build/src/config/rules.mk:731: recipe for target 'Interceptor.obj' failed
[task 2020-02-24T17:44:06.871Z] 17:44:06     INFO -  mozmake.EXE[4]: *** [Interceptor.obj] Error 1
[task 2020-02-24T17:44:06.871Z] 17:44:06     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/ipc/mscom'
[task 2020-02-24T17:44:06.871Z] 17:44:06     INFO -  mozmake.EXE[4]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79fca7b4d2c2
Provide operator== for mozilla::Nothing. r=froydnj

Comment 5

[Simon Giesecke [:sg] [he/him]]

Re-landed.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/79fca7b4d2c2