1617570 - [wpt-sync] Sync PR 21931 - [v8][wasm] Fix WebAssembly streaming tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21931 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21931
Details from upstream follow.

Andreas Haas <[e-mail]> wrote:

[v8][wasm] Fix WebAssembly streaming tests

This CL fixes a test that is checking the wrong behavior at the moment,
and disables the test until the fix in V8 lands.

Background:
The idea of the test is to create an invalid WebAssembly module, and
then check that the module is rejected by streaming compilation. The
invalid module was created by taking an empty module and adding two '0'
bytes at the end. However, two '0' bytes represent an empty unknown
section, which was originally accected by the streaming decoder. The
test, however, misinterpreted the test result (i.e. "FAIL Invalid code:
compileStreaming assert_unreached: Should have rejected: undefined
Reached unreachable decoder" a.k.a. FAIL, streaming compilation
succeeded unexpectedly) as the error message of the streaming compiler,
and then marked it in the test expectations as the expected behavior.

The CL changed the test now to add bytes that clearly create an invalid
module, and also deleted the invalid test expectations.

R=[e-mail]

Bug: v8:10126
Change-Id: Ie49a7a890abd841a85dc9f634308762ea07e5928

Reviewed-on: https://chromium-review.googlesource.com/2066907
WPT-Export-Revision: 77d750f3fb0f65b4a5a59324c16f87e4af9abe26

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8942e071cf4b81b8094518e27c9f7911bfe60e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 48 tests

Status Summary

Firefox

OK : 4
PASS : 8[GitHub] 52[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 4
PASS : 8

Safari

OK : 3
FAIL : 6
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c2e85318ea9
[wpt PR 21931] - [v8][wasm] Fix WebAssembly streaming tests, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2c2e85318ea9