jsshell - inconsistent perfherder schema for the js-bench framework (units vs unit)
Categories
(Testing :: Performance, defect, P3)
Tracking
(firefox81 fixed)
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: trink, Assigned: brunobrt, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
Attachments
(1 file, 1 obsolete file)
- uses suites.units instead of suites.unit
The ETL process has been fixing up the schema on ingestion but it would be better if it was fixed at the source.
|
||
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 4•5 years ago
|
||
I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.
|
|
||
Comment 5•5 years ago
|
||
(In reply to Bruno Bartolomasi from comment #4)
I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.
I would suggest submitting a patch like the abandoned one and pushing to try to see if there are still failures. If there are, we can go from there.
|
|
Assignee | |
Comment 6•5 years ago
|
||
(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #5)
(In reply to Bruno Bartolomasi from comment #4)
I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.
I would suggest submitting a patch like the abandoned one and pushing to try to see if there are still failures. If there are, we can go from there.
I don't have access to try, should I submit and go from there?
|
|
||
Comment 7•5 years ago
•
|
||
(In reply to Bruno Bartolomasi from comment #6)
I don't have access to try, should I submit and go from there?
If this isn't your first contribution then you can request try access. Otherwise, we can push your patch to try on your behalf.
https://www.mozilla.org/en-US/about/governance/policies/commit/
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 8•5 years ago
|
||
Bruno, if this is your first contribution, just attach your diff here and we'll push to try for you.
hg diff > jsshell_inconsistent_perfherder_schema.diff
Have you cloned the mozilla-central repository? Firefox Source Docs
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 9•5 years ago
|
||
|
|
Assignee | |
Comment 10•5 years ago
|
||
(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #8)
Bruno, if this is your first contribution, just attach your diff here and we'll push to try for you.
hg diff > jsshell_inconsistent_perfherder_schema.diff
Have you cloned the mozilla-central repository? Firefox Source Docs
This is not my first contribution, I've requested level 1 access and I was waiting to see if someone could vouch for me, but I figured it could take a while so I did what you said and pushed the same changes it was pushed before. I used hg diff > jsshell_inconsistent_perfherder_schema.diff but maybe I did something wrong, I got the message
Warning: found 1 untracked file (will not be submitted): testing/jsshell/jsshell_inconsistent_perfherder_schema.diff
|
||
Comment 12•5 years ago
|
||
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Description
•