1617661 - jsshell - inconsistent perfherder schema for the js-bench framework (units vs unit)

Status: RESOLVED FIXED

(Testing :: Performance, defect, P3)

Description

[Mike Trinkala [:trink]]

• uses suites.units instead of suites.unit

The ETL process has been fixing up the schema on ingestion but it would be better if it was fixed at the source.

Comment 1

[Geoff Brown [:gbrown]]

I guess that's coming from:

https://searchfox.org/mozilla-central/rev/96f1457323cc598a36f5701f8e67aedaf97acfcf/testing/jsshell/benchmark.py#91

Comment 2

[Octavian Negru]

Attachment: Bug 1617661 - jsshell - inconsistent perfherder schema for the js-bench framework (units vs unit)

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

When unassigning please update the priority.

Comment 4

[Bruno Bartolomasi]

I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Bruno Bartolomasi from comment #4)

I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.

I would suggest submitting a patch like the abandoned one and pushing to try to see if there are still failures. If there are, we can go from there.

Comment 6

[Bruno Bartolomasi]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #5)

(In reply to Bruno Bartolomasi from comment #4)

I took a look at the obsolete version and seems like just rewriting 'units' to 'unit' did not pass the tests. Are there any other files that call 'units' that weren't fixed? I woud like to work on this, but I'm not sure how to proceed.

I would suggest submitting a patch like the abandoned one and pushing to try to see if there are still failures. If there are, we can go from there.

I don't have access to try, should I submit and go from there?

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Bruno Bartolomasi from comment #6)

I don't have access to try, should I submit and go from there?

If this isn't your first contribution then you can request try access. Otherwise, we can push your patch to try on your behalf.

https://www.mozilla.org/en-US/about/governance/policies/commit/

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Bruno, if this is your first contribution, just attach your diff here and we'll push to try for you.
hg diff > jsshell_inconsistent_perfherder_schema.diff
Have you cloned the mozilla-central repository? Firefox Source Docs

Comment 9

[Bruno Bartolomasi]

Attachment: Bug 1617661 - fix inconsistent perfherder schema for the js-bench framework (units vs unit)

Comment 10

[Bruno Bartolomasi]

(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #8)

Bruno, if this is your first contribution, just attach your diff here and we'll push to try for you.
hg diff > jsshell_inconsistent_perfherder_schema.diff
Have you cloned the mozilla-central repository? Firefox Source Docs

This is not my first contribution, I've requested level 1 access and I was waiting to see if someone could vouch for me, but I figured it could take a while so I did what you said and pushed the same changes it was pushed before. I used hg diff > jsshell_inconsistent_perfherder_schema.diff but maybe I did something wrong, I got the message

Warning: found 1 untracked file (will not be submitted): testing/jsshell/jsshell_inconsistent_perfherder_schema.diff

Comment 11

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Congrats, Bruno! The patch was landed!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b618143ce21e
fix inconsistent perfherder schema for the js-bench framework (units vs unit) r=perftest-reviewers,AlexandruIonescu

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b618143ce21e