1617742 - It should be possible to open a composeAction popup from onBeforeSend

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Geoff Lankow (:darktrojan)]

There's two issues here:

1. browser.composeAction.openPopup doesn't work at all.
2. onBeforeSend isn't considered a user action so openPopup can't be called from it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1617742-onbeforesend-openpopup-1.diff

Finding the right window to open the popup in is a bit ugly (XPCOM window handling functions are badly lacking some useful things IMO) but any window other than the most recent is unlikely to be the right window.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9128638 [details] [diff] [review]
1617742-onbeforesend-openpopup-1.diff

Review of attachment 9128638 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f34fd430a920
Enable opening of composeAction popups by onBeforeSend listener. r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2aeba9647436