Move mutation of LoadInfo for DocumentChannel into the parent process
Categories
(Core :: DOM: Networking, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(4 files)
In bug 1617500, I want to try constructing LoadInfo entirely in the parent process with DocumentChannel, so that we can have a single path for both docshell-initiated loads as well as CanonicalBrowsingContext-initiated loads.
We currently have a bunch of code that configures our LoadInfo using the nsDocShellLoadState, and we can move this into CreateAndConfigureRealChannelForLoadState so that it runs in the parent process with DocumentChannel.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D63995
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D63996
|
|
Assignee | |
Comment 4•3 years ago
|
||
We currently extract Document pointers from the old LoadInfo, and attach them to the new one, such that they aren't lost during serialization.
This moves us to setting them more directly from their original source, since the old LoadInfo is no longer reliable (and was only configured fully in the parent process).
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98ea95f7fe87 Don't require loadInfo for navigate-to. r=nika https://hg.mozilla.org/integration/autoland/rev/f3518664d654 Simplify load from external. r=nika https://hg.mozilla.org/integration/autoland/rev/995edb2e7f98 Move loadInfo configuration into CreateAndConfigureRealChannelForLoadState so that it runs in the parent process with DocumentChannel. r=nika https://hg.mozilla.org/integration/autoland/rev/592a5ddf6acf Set content process Document pointer without relying on LoadInfo. r=nika
|
||
Comment 6•3 years ago
|
||
Backed out 7 changesets (bug 1617500, bug 1617789, bug 1617434) for build bustage in dom/clients/manager/ClientChannelHelper.cpp
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291144779&repo=autoland&lineNumber=28560
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=1a62904bfcb7345ea90841e179e8aea5e88ffac8
Backout:
https://hg.mozilla.org/integration/autoland/rev/d9db62e5092eaeefb7049b150bdd775016c9a62d
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/269def105275 Don't require loadInfo for navigate-to. r=nika https://hg.mozilla.org/integration/autoland/rev/8b2f20cab5e9 Simplify load from external. r=nika https://hg.mozilla.org/integration/autoland/rev/ab7787929c48 Move loadInfo configuration into CreateAndConfigureRealChannelForLoadState so that it runs in the parent process with DocumentChannel. r=nika https://hg.mozilla.org/integration/autoland/rev/437da2aca7a0 Set content process Document pointer without relying on LoadInfo. r=nika
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/269def105275
https://hg.mozilla.org/mozilla-central/rev/8b2f20cab5e9
https://hg.mozilla.org/mozilla-central/rev/ab7787929c48
https://hg.mozilla.org/mozilla-central/rev/437da2aca7a0
|
|
Assignee | |
Updated•3 years ago
|
Description
•