Closed Bug 1617858 Opened 4 years ago Closed 4 years ago

[Linux] White vertical bar in native-styled select dropdown widget, on Ubuntu 19.10

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
Desktop
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox73 --- wontfix
firefox74 + verified
firefox75 --- verified

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(1 file)

Bug 1617858 [Linux/Gtk] Don't use a fallback widget when it's missing, r?jhorak
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

With Bug 1613130 fixed we may not need a fallback widget so let's remove this workaround.

See Also: → 1614421
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5783f1f17d8
[Linux/Gtk] Don't use a fallback widget when it's missing, r=jhorak

https://hg.mozilla.org/mozilla-central/rev/b5783f1f17d8

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

Tracking for 74 as we want to uplift it in our last beta.

tracking-firefox74: --- → +

Comment on attachment 9128767 [details]
Bug 1617858 [Linux/Gtk] Don't use a fallback widget when it's missing, r?jhorak

Beta/Release Uplift Approval Request

  • User impact if declined: White line at dropbox / Yaru Gtk theme.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 0) use Ubuntu with Yaru theme
  1. load url:
    data:text/html,<select>
  2. check there isn't any thin white or black line there
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): linux theme fix
  • String changes made/needed: none
Attachment #9128767 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Worked for me!

Thanks!

QA Whiteboard: [qa-triaged]

Comment on attachment 9128767 [details]
Bug 1617858 [Linux/Gtk] Don't use a fallback widget when it's missing, r?jhorak

Linux theme fix, uplift approved for 74 beta 9, thanks.

Attachment #9128767 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have reproduced this issue on Beta v74.0b8 and verified it in Beta v74.0b9 and Nightly v75.0a1 from 2020-02-28 on Ubuntu 18 with theme Yaru-Dark.

Status: RESOLVED → VERIFIED
status-firefox74: fixed → verified
status-firefox75: fixed → verified
Flags: qe-verify+
OS: Unspecified → Linux
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: