Closed Bug 1618058 Opened 1 year ago Closed 1 year ago

Implement the GV Autocomplete API for login autocomplete

Categories

(GeckoView :: General, task, P1)

All
Android

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: MattN, Assigned: esawin)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [geckoview:m77][geckoview:m78])

Attachments

(5 files, 4 obsolete files)

To allow the user to fill in a login without typing when there is more than one saved for the site (e.g. or related subdomain), the user should be able to select from some "autocomplete" UI (using the term from desktop). The API could also return return results for password generation.

We can make the API generic so that it can handle autocomplete of future data such as form history, address profiles, and credit card profiles.

We may probably need to change https://searchfox.org/mozilla-central/rev/96f1457323cc598a36f5701f8e67aedaf97acfcf/toolkit/components/satchel/nsFormFillController.cpp#975-1001 as part of this.

Rank: 20
Priority: -- → P2
Assignee: nobody → esawin
Whiteboard: [geckoview:m76]
Priority: P2 → P1
Blocks: 1626657
No longer blocks: 1626657
Type: enhancement → task
Summary: Provide a GV autocomplete API (initially for login autocomplete) → Implement the GV Autocomplete API for login autocomplete
Whiteboard: [geckoview:m76] → [geckoview:m77]
Blocks: 1626657
Depends on: 1626660
Whiteboard: [geckoview:m77] → [geckoview:m77][geckoview:m78]
Status: NEW → ASSIGNED

Depends on D73057

Attachment #9144334 - Attachment description: Bug 1618058 - [1.0] Add Autocomplete API for login autocomplete. → Bug 1618058 - [1.1] Add Autocomplete API for login autocomplete.
Attachment #9144336 - Attachment description: Bug 1618058 - [2.b.0] Refactor LoginStorage backend API to the Autocomplete backend API. → Bug 1618058 - [2.b.1] Refactor LoginStorage backend API to the Autocomplete backend API.
Attachment #9144337 - Attachment is obsolete: true
Attachment #9144338 - Attachment is obsolete: true
Attachment #9144334 - Attachment description: Bug 1618058 - [1.1] Add Autocomplete API for login autocomplete. → Bug 1618058 - [1.2] Add Autocomplete API for login autocomplete.
Attachment #9144339 - Attachment description: Bug 1618058 - [3.0] Rename and extend LoginStorage tests to Autocomplete tests. → Bug 1618058 - [3.1] Rename and extend LoginStorage tests to Autocomplete tests.
Attachment #9144334 - Attachment description: Bug 1618058 - [1.2] Add Autocomplete API for login autocomplete. → Bug 1618058 - [1.3] Add Autocomplete API for login autocomplete.
Attachment #9144336 - Attachment description: Bug 1618058 - [2.b.1] Refactor LoginStorage backend API to the Autocomplete backend API. → Bug 1618058 - [2.b.2] Refactor LoginStorage backend API to the Autocomplete backend API.
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.1] Implement Autocomplete API backend. → Bug 1618058 - [2.c.2] Implement Autocomplete API backend.
Attachment #9144339 - Attachment description: Bug 1618058 - [3.1] Rename and extend LoginStorage tests to Autocomplete tests. → Bug 1618058 - [3.2] Rename and extend LoginStorage tests to Autocomplete tests.

Depends on D73060

Attachment #9147304 - Attachment description: Bug 1618058 - [4.0] Update API changelog. → Bug 1618058 - [4.1] Update API changelog.
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.2] Implement Autocomplete API backend. → Bug 1618058 - [2.c.3] Implement Autocomplete API backend.
Attachment #9145618 - Attachment is obsolete: true
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.3] Implement Autocomplete API backend. → Bug 1618058 - [2.c.4] Implement Autocomplete API backend.
Attachment #9144339 - Attachment description: Bug 1618058 - [3.2] Rename and extend LoginStorage tests to Autocomplete tests. → Bug 1618058 - [3.3] Rename and extend LoginStorage tests to Autocomplete tests.
Attachment #9144334 - Attachment description: Bug 1618058 - [1.3] Add Autocomplete API for login autocomplete. → Bug 1618058 - [1.4] Add Autocomplete API for login autocomplete.
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.4] Implement Autocomplete API backend. → Bug 1618058 - [2.c.5] Implement Autocomplete API backend.
Attachment #9147304 - Attachment description: Bug 1618058 - [4.1] Update API changelog. → Bug 1618058 - [4.2] Update API changelog.
Attachment #9144336 - Attachment description: Bug 1618058 - [2.b.2] Refactor LoginStorage backend API to the Autocomplete backend API. → Bug 1618058 - [2.b.3] Refactor LoginStorage backend API to the Autocomplete backend API.
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.5] Implement Autocomplete API backend. → Bug 1618058 - [2.c.6] Implement Autocomplete API backend.
Attachment #9145617 - Attachment description: Bug 1618058 - [2.c.6] Implement Autocomplete API backend. → Bug 1618058 - [2.c.7] Implement Autocomplete API backend.
Attachment #9147304 - Attachment description: Bug 1618058 - [4.2] Update API changelog. → Bug 1618058 - [4.3] Update API changelog.
Attachment #9144335 - Attachment is obsolete: true
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e975470f4a8c
[1.4] Add Autocomplete API for login autocomplete. r=geckoview-reviewers,snorp,agi
https://hg.mozilla.org/integration/autoland/rev/70271922b7d4
[2.b.3] Refactor LoginStorage backend API to the Autocomplete backend API. r=geckoview-reviewers,droeh
https://hg.mozilla.org/integration/autoland/rev/0929113893bd
[2.c.7] Implement Autocomplete API backend. r=geckoview-reviewers,MattN,aklotz
https://hg.mozilla.org/integration/autoland/rev/106285c88a85
[3.3] Rename and extend LoginStorage tests to Autocomplete tests. r=geckoview-reviewers,agi,snorp
https://hg.mozilla.org/integration/autoland/rev/b02d2e7140bc
[4.3] Update API changelog. r=geckoview-reviewers,agi
Blocks: 1654369
You need to log in before you can comment on or make changes to this bug.