1618121 - CheckedUnsafePtr should be a literal type and trivially copyable if checking is disabled

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1618121 - Make CheckedUnsafePtr a literal type and trivially copyable if checking is disabled, and add get member function. r=#dom-workers-and-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b874484bdeb7
Make CheckedUnsafePtr a literal type and trivially copyable if checking is disabled, and add get member function r=dom-workers-and-storage-reviewers,edenchuang

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for assertion failure at nsTArray.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/e230c3be11df3c05a9b10dbb1b81b36a0d9e9305
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292805286&repo=autoland&lineNumber=10118

Comment 4

[Narcis Beleuzu [:NarcisB]]

There were also crashes on InvalidArrayIndex_CRASH
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292805437&repo=autoland&lineNumber=1976

Comment 5

[Simon Giesecke [:sg] [he/him]]

There was a bug in the copy assignment operator, which was not covered by the unit tests, so this slipped through. I added unit test cases and fixed the bug. Try looks fine now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08e503064e5c7a5c42679f3d81af1cee29ccc99d Will reland the patch now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e0a1c83694c
Make CheckedUnsafePtr a literal type and trivially copyable if checking is disabled, and add get member function. r=dom-workers-and-storage-reviewers,edenchuang

Comment 7

[Oana Pop-Rus]

Backed out 2 changesets (bug 1618121, bug 1617993) for build bustages in CheckedUnsafePtr.h

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=2658800d6c7801f1d192b230db4576c65e31fb8c&selectedJob=292847297

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292847297&repo=autoland&lineNumber=11658

Backout: https://hg.mozilla.org/integration/autoland/rev/39473fcaf9721589bb0a37abf03485add1223035

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ce94e16652c
Make CheckedUnsafePtr a literal type and trivially copyable if checking is disabled, and add get member function. r=dom-workers-and-storage-reviewers,edenchuang

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0ce94e16652c