1618221 - "Fill Password" toggles the autocomplete dropdown if password generation was dismissed before

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Andrei Purice]

Attachment: Fill Password toggles the autocomplete dropdown if password generation was dismissed before.mp4

Affected platforms:
All

Steps to reproduce:

1. Launch Firefox
2. Go to facebook.com
3. Save 1 set of credentials
4. Right click the password field
5. Select "Use Generated Password"
6. Click out of the autocomplete dropdown to dismiss it
7. Right click -> Fill Password -> previously saved user

Expected:
The autocomplete dropdown should not be toggled and the password field should be filled with the selected credential

Actual:
The password field is filled in while the autocomplete dropdown is also displayed with the generation option.

Regression-Range:

3:48.01 INFO: Got as far as we can go bisecting nightlies...
3:48.01 INFO: Last good revision: 2c912e46295e4f8a3fa5824a7f378e06760ec7dd (2019-11-22)
3:48.01 INFO: First bad revision: d2d4fba86fce4ca4391e1886dd195b286d794ac0 (2019-11-23)
3:48.01 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c912e46295e4f8a3fa5824a7f378e06760ec7dd&tochange=d2d4fba86fce4ca4391e1886dd195b286d794ac0

Note that in Nightly 72.0a1 (2019-11-23) was introduced the new functionality of "Use Generated Password" from the context menu which opened the autocomplete dropdown to preview the generated password instead of filling it directly in the field.
So this is basically a regression of that new implementation.

Comment 1

[Matthew N. [:MattN]]

This is caused by https://searchfox.org/mozilla-central/rev/49ed791eec93335abfe6c2880f84c324e73e47e6/toolkit/components/passwordmgr/LoginAutoCompleteResult.jsm#503. Perhaps we could remove from _fieldsWithPasswordGenerationForcedOn after the field is filled or cleared but that may not be what the user expects. I really wish we left the context menu filling the generated password directly…

P3 because I don't think this is that severe of a problem, just an annoyance.