Closed Bug 1618265 Opened 5 years ago Closed 5 years ago

Panning/zooming doesn't reset between navigations

Categories

(GeckoView :: General, defect, P1)

Unspecified
All
defect

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

Attachments

(1 file)

Recent (today's) Fenix nightly has a problem where the pan/zoom is not reset between navigations.

Kats, Botond: I'm going to try to mozregression this, but maybe you know of recent changes that may have caused a problem?

Flags: needinfo?(kats)
Flags: needinfo?(botond)

I'm not aware of anything

Flags: needinfo?(kats)

This doesn't seem to occur all the time. Looks like we need to get reliable STR.

This seems to be a problem when using a GeckoSession with restored state. Thanks to rbarker for these STR:

  1. Open a page and scroll/zoom somewhere
  2. Go to the homescreen and force quit the app
  3. Launch Fenix, open the tab from 1)
  4. Observe that scroll/zoom is correctly restored
  5. Navigate to another page, either by clicking a link or entering from urlbar
  6. Observe that new page is incorrectly panned/zoom to old position

This sounds like maybe the listener we set up to restore scroll position is not getting removed somehow: https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContentChild.js#242 -- but nothing there has changed recently, so I'm not sure why it would crop up now.

(In reply to Dylan Roeh (:droeh) (he/him) from comment #5)

This sounds like maybe the listener we set up to restore scroll position is not getting removed somehow: https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContentChild.js#242 -- but nothing there has changed recently, so I'm not sure why it would crop up now.

Yeah, I think it's something like this. I'm having trouble reproducing in GVE, so it's not clear yet. I have verified that Fenix isn't calling restoreState() erroneously, though.

I'm also not aware of anything APZ-related having landed in the last few days that might cause this.

Flags: needinfo?(botond)

I've found the cause. It's a regression from bug 1554302, but it really just exposes an existing bug. Patch coming.

Assignee: nobody → snorp
Status: NEW → ASSIGNED
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e94323359dfa Correctly disconnect from 'pageshow' event r=droeh
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/827aeb063964 Fix prettier eslint failure on GeckoViewContentChild.js. r=eslint-fix
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: