Panning/zooming doesn't reset between navigations
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: snorp, Assigned: snorp)
Details
Attachments
(1 file)
Recent (today's) Fenix nightly has a problem where the pan/zoom is not reset between navigations.
Assignee | ||
Comment 1•5 years ago
|
||
Kats, Botond: I'm going to try to mozregression
this, but maybe you know of recent changes that may have caused a problem?
Assignee | ||
Comment 3•5 years ago
|
||
This doesn't seem to occur all the time. Looks like we need to get reliable STR.
Assignee | ||
Comment 4•5 years ago
|
||
This seems to be a problem when using a GeckoSession
with restored state. Thanks to rbarker for these STR:
- Open a page and scroll/zoom somewhere
- Go to the homescreen and force quit the app
- Launch Fenix, open the tab from 1)
- Observe that scroll/zoom is correctly restored
- Navigate to another page, either by clicking a link or entering from urlbar
- Observe that new page is incorrectly panned/zoom to old position
Comment 5•5 years ago
|
||
This sounds like maybe the listener we set up to restore scroll position is not getting removed somehow: https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContentChild.js#242 -- but nothing there has changed recently, so I'm not sure why it would crop up now.
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Dylan Roeh (:droeh) (he/him) from comment #5)
This sounds like maybe the listener we set up to restore scroll position is not getting removed somehow: https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContentChild.js#242 -- but nothing there has changed recently, so I'm not sure why it would crop up now.
Yeah, I think it's something like this. I'm having trouble reproducing in GVE, so it's not clear yet. I have verified that Fenix isn't calling restoreState()
erroneously, though.
Comment 7•5 years ago
|
||
I'm also not aware of anything APZ-related having landed in the last few days that might cause this.
Assignee | ||
Comment 8•5 years ago
|
||
I've found the cause. It's a regression from bug 1554302, but it really just exposes an existing bug. Patch coming.
Assignee | ||
Comment 9•5 years ago
|
||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e94323359dfa
https://hg.mozilla.org/mozilla-central/rev/827aeb063964
Description
•