Closed Bug 1618304 Opened 1 year ago Closed 1 year ago

Update import icon and text for about:logins

Categories

(Firefox :: about:logins, enhancement, P1)

Product:
Firefox
Component:
about:logins
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Flags:
Tracking Status
firefox75 --- verified
firefox76 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

current about:logins import options
365.02 KB, image/png
Details
Bug 1618304 - Update import icon and text for about:logins r?MattN!
47 bytes, text/x-phabricator-request
Details | Review

Bryan has some ideas on making importing more visible from about:logins. Looks like when there's no passwords, there's messaging already to set up sync and to import at the bottom. And there's a persistent menu item to import too.

Flags: needinfo?(bbell)
Priority: -- → P2

Actually no current plans for changing the existing import entrypoints, but maybe I'll just rescope this to be consistent with the icon from bug 1618346.

Assignee: nobody → edilee
Depends on: 1618346
Flags: needinfo?(bbell)
Summary: Make migrating more prominent from about:logins → Update import icon about:logins

Depends on D65420

Depends on D65420

We have been wanting to re-label the menu item to something more like the file menu or bug 1618346 since people think they can import from other password managers and sometimes the browser they choose doesn't support password import (Safari). If you wanted to do that at the same time it would be nice but up to you.

Attachment #9130931 - Attachment description: Bug 1618304 - Update import icon for about:logins r?MattN! → Bug 1618304 - Update import icon and text for about:logins r?MattN!
Iteration: --- → 75.2 - Feb 24 - Mar 8
Priority: P2 → P1
Summary: Update import icon about:logins → Update import icon and text for about:logins
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/159aa4a20e90
Update import icon and text for about:logins r=MattN,fluent-reviewers,flod

https://hg.mozilla.org/mozilla-central/rev/159aa4a20e90

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
QA Whiteboard: [qa-75b-p2]

I have verified this issue and the import icon with the "Import from Another Browser…" string are correctly displayed on "about:logins" page. Tested on Firefox Beta 75.0b3 (Build ID: 20200313021419) and the latest Nightly 76.0a1 build (Build ID: 20200312215313) on Windows 10 x64, Mac 10.14 and Arch Linux.

  • Verified that the icon and the string are correctly displayed in the menu.
  • Verified that the icon and the string are correctly displayed on the dark and light themes.
  • Verified that the string is correctly displayed and localized in the following builds: "en-US", "de", "es-ES", "ru", "zh-CN" and "ar".
    • Please note that the string is not yet localized on "ar" build.
  • Verified that the Import option is not displayed on Linux.
Status: RESOLVED → VERIFIED
status-firefox75: fixed → verified
status-firefox76: --- → verified
You need to log in before you can comment on or make changes to this bug.