1618314 - Remove import suggestions on user opt-out or automatically

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Ed Lee :Mardak]

With bug 1618311, we'll add some autocomplete entries, but we should allow users to get rid of them explicitly and probably some automatic trigger too, e.g., existing saved password or profile age??

We'll want telemetry around this too.

One idea could be like attachment 9128834 [details] with a remove "X" button within an entry.

Comment 1

[Matthew N. [:MattN]]

Is this still considered a P1? Not a big deal either way but I wanted to make sure it didn't fall off your radar if you wanted it on there :)

Comment 2

[Ed Lee :Mardak]

We most likely want to stop showing the import suggestion if the user decides to ignore it especially to avoid annoying long time users (who decide to not have a saved password in Firefox). The experiment happened to unenroll users after 4 weeks.

jimt, do we want to have a time based cutoff or total impression count or something else?

Comment 3

[Ed Lee :Mardak]

Jim says the intention is to have 3 suggestions shown before hiding. Multiple views on the same page, e.g., username field + password field, should be treated as one.

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1618314 - Remove import suggestions on user opt-out or automatically r?MattN

Allow 3 showing of import suggestions debouncing multiple impressions within 10 seconds. Also treat deleting a suggestion as opt-out.

Comment 5

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: the password autocomplete functionality is on by default in 81 and this enhancement is important for opt-out users

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceee87c2f7d8
Remove import suggestions on user opt-out or automatically r=MattN

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ceee87c2f7d8

Comment 8

[Ed Lee :Mardak]

Could you verify this on the next 82 nightly for 81 uplift? Also, with this change, testing the feature many tines will probably require resetting signon.suggestImportCount to get it to show again.

Comment 9

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the behavior is the one described.
After the suggestion is displayed three times it is no longer displayed. It seems this is true as long as there are more than 10 seconds in total between the current try and the last 2 where it was displayed.
Tested on Firefox Nightly 82.0a1 (Build ID: 20200901094542) on Windows 10.

Comment 10

[Ed Lee :Mardak]

Comment on attachment 9171289 [details]
Bug 1618314 - Remove import suggestions on user opt-out or automatically r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: Users who ignore import suggestions might get annoyed by them showing up on every login field without a saved password.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Similar to comment 9:

1. have at least 4 importable logins from chrome for different sites
2. open new profile in firefox
3. navigate to site with saved chrome login
4. wait at least 10 seconds after seeing the import suggestion
5. repeat steps 3+4 for the 3+ other sites

expect: on the 4th (and later sites) there should be no more import suggestion shown

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Some parent/child messaging to update and check a new pref to turn off behavior. Not too risky as it doesn't affect many users and can be turned off via pref.
• String changes made/needed: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171289 [details]
Bug 1618314 - Remove import suggestions on user opt-out or automatically r?MattN

Approved for 81.0b5.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df8d1a303708

Comment 13

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following by using the steps provided in comment 10 on Firefox Beta 81.0b5 (Build ID: 2020091203141) with Windows 10, and macOS 10.15:

• The import suggestion can be successfully removed by deselecting the "Ask to save logins and passwords for websites" option in the "about:preferences#privacy" page.
• The import suggestion is automatically removed by seeing the import suggestion more than 3 times on different websites.