Closed
Bug 1618488
Opened 5 years ago
Closed 5 years ago
Add .get() to mViewSource in calls to P::transition in the tokenizer
Categories
(Core :: DOM: HTML Parser, task, P2)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla75
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
Assignee | ||
Updated•5 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/748266807263
Add .get() to mViewSource in calls to P::transition in the tokenizer. r=erahm
Assignee | ||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Comment 5•5 years ago
|
||
Henri, looks like we need to do the same for calls to P::completedNamedCharacterReference
:
0:15.21 In file included from Unified_cpp_parser_html1.cpp:83:
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5Tokenizer.cpp:1899:47: error: no viable conversion from 'mozilla::UniquePtr<nsHtml5Highlighter>' to 'nsHtml5Highlighter *'
0:15.21 P::completedNamedCharacterReference(mViewSource);
0:15.21 ^~~~~~~~~~~
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5Tokenizer.cpp:438:11: note: in instantiation of function template specialization 'nsHtml5Tokenizer::stateLoop<nsHtml5ViewSourcePolicy>' requested here
0:15.21 pos = stateLoop<nsHtml5ViewSourcePolicy>(state, c, pos, buffer->getBuffer(),
0:15.21 ^
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5TokenizerLoopPolicies.h:33:27: note: passing argument to parameter 'aHighlighter' here
0:15.21 nsHtml5Highlighter* aHighlighter) {
0:15.21 ^
0:15.21 In file included from Unified_cpp_parser_html1.cpp:83:
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5Tokenizer.cpp:1899:47: error: no viable conversion from 'mozilla::UniquePtr<nsHtml5Highlighter>' to 'nsHtml5Highlighter *'
0:15.21 P::completedNamedCharacterReference(mViewSource);
0:15.21 ^~~~~~~~~~~
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5Tokenizer.cpp:443:11: note: in instantiation of function template specialization 'nsHtml5Tokenizer::stateLoop<nsHtml5SilentPolicy>' requested here
0:15.21 pos = stateLoop<nsHtml5SilentPolicy>(state, c, pos, buffer->getBuffer(),
0:15.21 ^
0:15.21 /var/dev/erahm/mozilla-unified/parser/html/nsHtml5TokenizerLoopPolicies.h:19:27: note: passing argument to parameter 'aHighlighter' here
0:15.21 nsHtml5Highlighter* aHighlighter) {}
0:15.21 ^
0:15.21 2 errors generated.
Flags: needinfo?(hsivonen)
You need to log in
before you can comment on or make changes to this bug.
Description
•