1618631 - Make BCEScriptStencil own the pieces it requires to initialize a script

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Today, BCEScriptStencil delegates to a contained BytecodeEmitter reference in order to fill in a JSScript.

This needs to change, making BCEScriptStencil own this data, and making BCEScriptStencil movable type will allow us to re-home this on the FunctionTree after it has been filled in.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Run const through ObjLiteral code r?cfallin

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Store source notes and bytecode vectors in UniquePtrs r?tcampbell

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Make ScriptStencil own the BytecodeVector and Notes r?tcampbell

Depends on D65041

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Root GCThingList explicitly r?tcampbell

Depends on D65042

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Make Allocation of GC things a static method to prepare for sharing r?tcampbell

Depends on D65040

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Move ownership of GCThings vector to ScriptStencil r?tcampbell

Depends on D65044

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8534818e5d
Run const through ObjLiteral code r=cfallin
https://hg.mozilla.org/integration/autoland/rev/8422da053e07
Make Allocation of GC things a static method to prepare for sharing r=tcampbell

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5c8534818e5d
https://hg.mozilla.org/mozilla-central/rev/8422da053e07

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5598b077ccea
Move ownership of GCThings vector to ScriptStencil r=tcampbell,jorendorff

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5598b077ccea

Comment 11

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Pass preallocated RuntimeScriptData to stencil rather than ImmutableScriptData. r?tcampbell

Comment 12

[Phabricator Automation]

Comment on attachment 9135228 [details]
Bug 1618631 - Pass preallocated RuntimeScriptData to stencil rather than ImmutableScriptData. r?tcampbell

Revision D67920 was moved to bug 1625591. Setting attachment 9135228 [details] to obsolete.

Comment 13

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1618631 - Minimize dependency on BytecodeEmitter member of BCEScriptStencil

This is preparation for disconnecting BCEScriptStencil from the BytecodeEmitter
to allow subsequent batch initialization, by making it more clear what still
depends on the BCE.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057bd6b8d85b
Minimize dependency on BytecodeEmitter member of BCEScriptStencil r=tcampbell

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/057bd6b8d85b

Comment 16

[Ted Campbell [:tcampbell]]

With Bug 1638470, I think we'll be able to call this done :)