161865 - GetFieldID shouldn't INSERT into the fielddefs table

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Bradley Baetz (:bbaetz)]

This has been bothering me for a while.

GetFieldID has the interesting habit of inserting entries if it can't find them.
This leads to bugs like bug 157505, plus another similar one we had recently
which I can't seem to find. This is also caueing problems when I try to work out
where an extra entry is coming from in my patch for bug 43600.

I've got a patch which converts this into a die (not a template error, since
this could come from anywhere really) and adds fielddefs which aren't in
checksetup.pl to the list to be created there.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 2

[Bradley Baetz (:bbaetz)]

-> me

Comment 3

[Joel Peshkin]

Comment on attachment 94607 [details] [diff] [review]
patch

r= by Joel
Checked original source of this insert and it dates back to the original
addition of the fielddefs table before checksetup knew what to do with it.

Comment 4

[Bradley Baetz (:bbaetz)]

Fixed.